Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gestures cause cells to be misaligned #11

Open
Sumukh opened this issue Aug 15, 2014 · 11 comments
Open

Gestures cause cells to be misaligned #11

Sumukh opened this issue Aug 15, 2014 · 11 comments

Comments

@Sumukh
Copy link

Sumukh commented Aug 15, 2014

Gestures

Is keeping track of the touch position necessary? The gesture recognizer could just trigger the normal transition?

@andreamazz
Copy link
Owner

Hi @Sumukh
Can you elaborate? How can I reproduce the issue?

@Sumukh
Copy link
Author

Sumukh commented Aug 28, 2014

This behavior was triggered with a swipe from the left of the screen after selecting a row. Using that gesture causes the cells to be misaligned. I'll take another look at it soon.

@andreamazz
Copy link
Owner

Which iOS version are you running?
Also, make sure that you are running the latest commit in the repo, IIRC that bug was fixed.
I'll push a new version on cocoapods.

@andreamazz
Copy link
Owner

Ok, version 0.5.2 is up, looks like I forgot to push some changes, sorry.

@Sumukh
Copy link
Author

Sumukh commented Sep 1, 2014

I just pulled and it has the same issue (on a left swipe). I should have mentioned that I'm on iOS 8.

@cuva
Copy link

cuva commented Sep 4, 2014

First and foremost: very nice library - good job.

I have the same problem here on iOS 8 Beta 5 (Xcode beta 6). Everything works fine as long as the interactiveTransition is not being used. It happens on the Demo app launched in the sim.

Is this an issue you're planning on looking into sometime soon?

Cheers,

@andreamazz
Copy link
Owner

Hi.
Yes, right now in iOS8 the gesture is rather glitchy, I'll work on it in the next few days, it should be rather trivial. I'll keep you posted.

@cuva
Copy link

cuva commented Sep 4, 2014

Fantastic. Thanks for the update.

@Sashke
Copy link

Sashke commented Sep 11, 2014

To fix this behavior just place adding subview before kick cells of toVC, and replace [self.navigationController.view addSubview:toVC.view] with [self.navigationController.view insertSubview:toVC.view belowSubview:self.navigationController.navigationBar];
You can check my fork, branch "Sashke".

@andreamazz
Copy link
Owner

Brilliant, thanks @Sashke, your fix works like a charm.
@Sumukh checkout the latest commit and let me know if the issue is gone.

andreamazz added a commit that referenced this issue Sep 15, 2014
@cuva
Copy link

cuva commented Sep 16, 2014

Hey @andreamazz

Thanks for fixing this, It indeed appears to fix the interactive issue on iOS8. However the fix above introduces a problem if using a navigation controller without a navigation bar.

It works just fine when using the back button, but the interactive back gesture doesn't behaves as expected. Please see the following minimal sample project for iOS 8 (I've applied manually the latest commit in the Pods dep): https://github.com/cuva/TestAMWaveTransition

I've tried to discover where it comes from but modifying the Y values didn't seem to make much change.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants