-
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gestures cause cells to be misaligned #11
Comments
Hi @Sumukh |
This behavior was triggered with a swipe from the left of the screen after selecting a row. Using that gesture causes the cells to be misaligned. I'll take another look at it soon. |
Which iOS version are you running? |
Ok, version 0.5.2 is up, looks like I forgot to push some changes, sorry. |
I just pulled and it has the same issue (on a left swipe). I should have mentioned that I'm on iOS 8. |
First and foremost: very nice library - good job. I have the same problem here on iOS 8 Beta 5 (Xcode beta 6). Everything works fine as long as the interactiveTransition is not being used. It happens on the Demo app launched in the sim. Is this an issue you're planning on looking into sometime soon? Cheers, |
Hi. |
Fantastic. Thanks for the update. |
To fix this behavior just place adding subview before kick cells of toVC, and replace [self.navigationController.view addSubview:toVC.view] with [self.navigationController.view insertSubview:toVC.view belowSubview:self.navigationController.navigationBar]; |
Hey @andreamazz Thanks for fixing this, It indeed appears to fix the interactive issue on iOS8. However the fix above introduces a problem if using a navigation controller without a navigation bar. It works just fine when using the back button, but the interactive back gesture doesn't behaves as expected. Please see the following minimal sample project for iOS 8 (I've applied manually the latest commit in the Pods dep): https://github.com/cuva/TestAMWaveTransition I've tried to discover where it comes from but modifying the Y values didn't seem to make much change. Cheers. |
Is keeping track of the touch position necessary? The gesture recognizer could just trigger the normal transition?
The text was updated successfully, but these errors were encountered: