Wait for initrd to complete before initrd flash script exits #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `expect` to watch the serial console of a device being flashed. This allows scripting of the initrd flash script based on exit code. If the flash fails, the script exits with code 1.
|
Negative on this implementation. I don't want to take over the serial console to wait for this, since other scripts may be watching serial console simultaneously. We should instead be able to get this signal over the USB port somehow, since we know we have exclusive access to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Use
expectto watch the serial console of a device being flashed. This allows scripting of the initrd flash script based on exit code. If the flash fails, the script exits with code 1.Other changes include fixing the debug shell.
Fixes #84
Testing
Tested on an orin agx devkit