Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moodle LMS Identification and SSL Broken #1

Open
jrchamp opened this issue Mar 18, 2014 · 0 comments
Open

Moodle LMS Identification and SSL Broken #1

jrchamp opened this issue Mar 18, 2014 · 0 comments

Comments

@jrchamp
Copy link

jrchamp commented Mar 18, 2014

The assumption that "Moodle does not use frames" in the initial bookmarklet code assumes that the required template branding for an organization also does not use frames. The frames check doesn't really buy us anything anyway.

Additionally, the bookmarklet does not work with HTTPS-only Moodle installations as a result of cross-domain origin issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrchamp