Skip to content
This repository has been archived by the owner on Jul 10, 2018. It is now read-only.

Add more specific contexts #38

Open
2 tasks
joshangell opened this issue Mar 31, 2016 · 13 comments
Open
2 tasks

Add more specific contexts #38

joshangell opened this issue Mar 31, 2016 · 13 comments
Labels
Milestone

Comments

@joshangell
Copy link
Member

Related to #28 and #33 there are some obvious contexts that need adding - feel free to comment to add more:

  • Matrix fields in SuperTable fields - support all current contexts (Entry types, Category groups, Global sets, Users)
  • Asset sources
@joshangell joshangell modified the milestone: 2.2 Mar 31, 2016
@joshangell joshangell self-assigned this Mar 31, 2016
@aladrach
Copy link

aladrach commented Apr 4, 2016

Were any of these fixes supposed to be included in the latest 2.1.3 update? I see in one of the items fixed:
Fixed numerous situations where matrix fields were turning up blank e.g. element editor HUDs and nested SuperTable Matrix fields.

But it still appears that the nested fields with SuperTable and Matrix are not loading. See use case below:

screen shot 2016-04-04 at 12 28 39 pm

@joshangell
Copy link
Member Author

@aladrach I'll take a look today for you, that may have got missed!

@joshangell
Copy link
Member Author

@aladrach aha, I’ve found the scenario, it only happens when there is a block-specific field layout that contains a SuperTable / Matrix combo and only happens on load. You can get round it for now by either collapsing and expanding the affected blocks, or removing the field layout for that block. I've made a specific ticket if you want to follow that: #40

@dubcanada
Copy link

@joshangell Any idea of where to start looking at adding Supertable support for Pimp My Matrix? I need it for a site.

@joshangell
Copy link
Member Author

@dubcanada sorry I haven’t actually looked into it - I think there will be a fair bit of js fangling to do. Feel free to take a shot and send a PR!

@roberttolton
Copy link

roberttolton commented May 26, 2016

Looks like I'm trying to use the same setup as @aladrach but I don't have the problem of the fields not loading, but rather the group field layouts are completely ignored. E.g where in @aladrach 's screenshot the "Blocks" button inside the SuperTable row, even though I've configured that to appear, I just get the default Matrix row-of-buttons UI and no Content / Settings tabs on the Matrix fields.

EDIT: Just updated to 2.1.4 and all seems to be good, except tabs.

screen shot 2016-05-26 at 11 02 57
image 2016-05-26 at 11 03 20 am

EDIT 2: But still getting the issue of fields not showing up upon first load of editing an entry, but collapse-and-open fixes it.

screen shot 2016-05-26 at 11 08 01

@joshangell
Copy link
Member Author

@fuelintegrated yep you can get around it either using @aladrach’s css fix (whatever that is) or removing the field layout for that block.

@roberttolton
Copy link

@joshangell I removed the field layout for the block, but the fields are still hidden :(

screen shot 2016-05-26 at 11 41 07

@joshangell
Copy link
Member Author

@fuelintegrated hmm, did you remove the global field layout for that block too? Or just the one specific to that entry type?

@roberttolton
Copy link

@joshangell There's still a field layout on the Column Module block type (you can see the Content / Settings tabs), would that be affecting it too?

@joshangell
Copy link
Member Author

@fuelintegrated aha quite possibly - if removing that fixes it then please could you document that on the #40 thread

@roberttolton
Copy link

@joshangell That seems to solve it yeah, I'll document on #40

@aladrach
Copy link

@joshangell, @fuelintegrated, this is the override CSS:

.matrixblock .fields {
    display: block !important;
}
.matrixblock.collapsed .fields {
    display: none !important;
}

@joshangell joshangell removed their assignment Dec 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants