From 0dc84968f254d595888595cd3ab7de6d98640136 Mon Sep 17 00:00:00 2001 From: Angelo Silvestre Date: Thu, 28 Dec 2023 19:27:13 -0300 Subject: [PATCH] Updates for #1538 --- .../example/lib/demos/example_editor/_toolbar.dart | 1 + super_editor/test/infrastructure/popover_test.dart | 7 ++++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/super_editor/example/lib/demos/example_editor/_toolbar.dart b/super_editor/example/lib/demos/example_editor/_toolbar.dart index f80cf22969..541865d7a9 100644 --- a/super_editor/example/lib/demos/example_editor/_toolbar.dart +++ b/super_editor/example/lib/demos/example_editor/_toolbar.dart @@ -633,6 +633,7 @@ class _EditorToolbarState extends State { icon: _buildTextAlignIcon(alignment), ), items: TextAlign.values + .where((alignment) => !const [TextAlign.start, TextAlign.end].contains(alignment)) .map( (alignment) => SuperEditorDemoIconItem( icon: _buildTextAlignIcon(alignment), diff --git a/super_editor/test/infrastructure/popover_test.dart b/super_editor/test/infrastructure/popover_test.dart index fd3a776fc4..1671738271 100644 --- a/super_editor/test/infrastructure/popover_test.dart +++ b/super_editor/test/infrastructure/popover_test.dart @@ -255,7 +255,8 @@ void main() { expect(popoverRect.bottom, lessThan(buttonRect.top)); }); - testWidgetsOnAllPlatforms('pins the popover to the bottom if there is not room below or above the button', + testWidgetsOnAllPlatforms( + 'pins the popover to the bottom of boundary if there is not room below or above the button', (tester) async { final boundaryKey = GlobalKey(); final buttonKey = GlobalKey(); @@ -416,8 +417,8 @@ void main() { expect(popoverRect.bottom, lessThan(buttonRect.top)); }); - testWidgetsOnAllPlatforms('pins the popover to the bottom if there is not room below or above the button', - (tester) async { + testWidgetsOnAllPlatforms( + 'pins the popover to the bottom of screen if there is not room below or above the button', (tester) async { final buttonKey = GlobalKey(); final popoverController = PopoverController();