From 916c7514d9dc7a1d1f82a8205b8a7d1232e5c302 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9s?= Date: Sat, 13 Oct 2018 23:37:55 +0200 Subject: [PATCH] after open hook fix --- CHANGELOG.md | 4 +++- lib/browser_core.js | 2 +- package-lock.json | 2 +- package.json | 2 +- tests/browser/open.test.js | 2 +- 5 files changed, 7 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3da2c899..81366d45 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,9 @@ -1.5.0 / ####-##-## +1.4.2 / ####-##-## ================== * AddScript method + * After Open hook fix + * Minor improvements to some error messages 1.4.1 / 2018-10-13 ================== diff --git a/lib/browser_core.js b/lib/browser_core.js index a8c89810..7b1260f3 100644 --- a/lib/browser_core.js +++ b/lib/browser_core.js @@ -53,7 +53,7 @@ module.exports = class BrowserCore { return this._afterPageLoad(); }); }).catch((err) => { - return Promise.reject(new FatalError(`Failed to open ${url}. ${err.message}`)); + return Promise.reject(new FatalError(`Failed to open "${url}". ${err.message}`)); }); } diff --git a/package-lock.json b/package-lock.json index 8a608d13..22be0c55 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "wendigo", - "version": "1.4.1", + "version": "1.4.2", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 4d37737a..f4e1a722 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "wendigo", - "version": "1.4.1", + "version": "1.4.2", "description": "A proper monster for front-end automated testing", "engines": { "node": ">=8.0.0" diff --git a/tests/browser/open.test.js b/tests/browser/open.test.js index ea7b36c7..5efb53ab 100644 --- a/tests/browser/open.test.js +++ b/tests/browser/open.test.js @@ -20,7 +20,7 @@ describe("Open", function() { it("Open Fails", async() => { await utils.assertThrowsAsync(async() => { await browser.open("not-a-page"); - }, `FatalError: Failed to open not-a-page. Protocol error (Page.navigate): Cannot navigate to invalid URL`); + }, `FatalError: Failed to open "not-a-page". Protocol error (Page.navigate): Cannot navigate to invalid URL`); }); it("Before Open Fails", async() => {