You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 4, 2017. It is now read-only.
In the documentation the router example under the imperative example it shows how to call the router via the TS API. This could be improved as we wouldn't want to encourage the usage of this API when a proper link should be used. This improves accessibility and SEO. This was pointed out by Marcy Sutton on twitter.
// Should use routerLink insteadonSelect(hero: Hero){this.router.navigate(['/hero',hero.id]);}
We should come up with a use case to use the imperative API when a routerLink is not appropriate.
I don't have any ideas of hand yet but working on brainstorming some. Maybe some kind of redirect use case? Maybe if not a specific use case we could add some information about why routerLink would be the better default option.
The text was updated successfully, but these errors were encountered:
In the documentation the router example under the imperative example it shows how to call the router via the TS API. This could be improved as we wouldn't want to encourage the usage of this API when a proper link should be used. This improves accessibility and SEO. This was pointed out by Marcy Sutton on twitter.
We should come up with a use case to use the imperative API when a routerLink is not appropriate.
I don't have any ideas of hand yet but working on brainstorming some. Maybe some kind of redirect use case? Maybe if not a specific use case we could add some information about why routerLink would be the better default option.
The text was updated successfully, but these errors were encountered: