Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set_var should not panic #97

Open
TyOverby opened this issue May 10, 2017 · 3 comments
Open

set_var should not panic #97

TyOverby opened this issue May 10, 2017 · 3 comments

Comments

@TyOverby
Copy link

values are often passed out of user-code to the rust program. set_var should return an Err and not panic.
@dragostis
Copy link
Member

Thank you for the issue. I agree with your point. Would you like to try and do a PR for this? :)

@TyOverby
Copy link
Author

Sure! I'll have some time this weekend if you don't mind waiting.

@dragostis
Copy link
Member

There's absolutelt no rush. I have a few ideas on how to improve the whole library and maybe launch a 2.0 sometime this year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TyOverby @dragostis