Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #1

Open
anishathalye opened this issue Jul 26, 2020 · 0 comments
Open

Windows support #1

anishathalye opened this issue Jul 26, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@anishathalye
Copy link
Owner

anishathalye commented Jul 26, 2020

I briefly tested Periscope on Windows, and in manual tests without tricky corner cases, it seems to work. The tests don't currently work -- the tests using testfs (which relies on afero's MemFs) seem to hang / OOM, and the tests using the real filesystem and fancy features like symlinks don't work either.

To support Windows, we need to:

  • Figure out why the MemFs-based tests aren't working, and fix them
  • Figure out why tests using the real filesystem aren't working, and either split them into separate files that are only used on macOS/Linux, or figure out how to adapt them to be cross-platform
  • Understand any potential subtleties of Periscope on Windows/NTFS, fix the code to handle these cases, and add Windows-specific tests

(I don't use Windows, so this is a low-priority issue for me. There's a good chance this will only be supported if someone can help out with this.)

@anishathalye anishathalye added the enhancement New feature or request label Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant