Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System and User Scope for settings #56

Closed
BCleverly opened this issue Jul 5, 2016 · 5 comments
Closed

System and User Scope for settings #56

BCleverly opened this issue Jul 5, 2016 · 5 comments

Comments

@BCleverly
Copy link

I've seen the extra coloumn example, but I'm not quite sure how i can work it into what I'm trying to do.

I want to use the package for system settings on a website, but i also want to have users settings in the same table/setup.

An example would be pricebands.
System default settings would be say
1, Value: 5 - Qty: 100
2, Value: 10 - Qty 200
3, Value: 20 - Qty 400
User settings would make this say:
1, Value: 5 - Qty: 100
2, Value: 7.5 - Qty 300
3, Value: 10 - Qty 600

Is this possible within this package or would we have to build something custom?

Many thanks

@anlutro
Copy link
Owner

anlutro commented Jul 5, 2016

So you basically want a set of global settings that can be overridden on a per-user basis? Would you want any setting to be overridden or only specific ones? Regardless, the feature isn't there today, but it might be something that makes sense to add.

@BCleverly
Copy link
Author

Basically yes.
I think that should be configurable, maybe by a flag in the database table row/model.
Would be nice to see this in the future and would set the package out from the rest.
I'll have a look at the package and see if i can work it into the package and make a pull request. Would you be able to label this as a feature request?

@anlutro
Copy link
Owner

anlutro commented Jul 6, 2016

If you'd like to help develop the feature that'd be awesome.

I think since this is a somewhat complex feature, I think creating an additional class that extends the DatabaseSettingStore would be a good idea to prevent subtle bugs from creeping in.

@BCleverly
Copy link
Author

I'll see what I can do, any questions etc I'll keep them in this issue thread.

@anlutro
Copy link
Owner

anlutro commented Oct 14, 2017

Sorry for the super late notification but I'm going through my issues and this is a duplicate of #3. I'm still interested in having it implemented, but will not be doing it myself (I'll be happy to help out anyone who wants to give it a shot).

@anlutro anlutro closed this as completed Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants