Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari icon color out of place and sometimes not visible #52

Open
marcolaux opened this issue Oct 1, 2024 · 5 comments
Open

Safari icon color out of place and sometimes not visible #52

marcolaux opened this issue Oct 1, 2024 · 5 comments

Comments

@marcolaux
Copy link

marcolaux commented Oct 1, 2024

The Safari icon is way to bright in dark situations

image

and way too dark in some dark situations (clicked on dark background)

image

would it be possible to blend it better like the default icons or as a workaround like other extensions do it?

image

Thank you for the hard work - I love the service 🙏

@Stjin
Copy link
Member

Stjin commented Oct 8, 2024

Working on it! 🚀

I already noticed myself and fixed this in source but I decided to push the release until the next general version of the extension, but since it's bothering someone now I will fix it right away! :)

@Stjin
Copy link
Member

Stjin commented Oct 9, 2024

This has now been fixed!

@marcolaux
Copy link
Author

marcolaux commented Oct 9, 2024

Thank you very much, looks good.

Just a minor thing. It doesn't seem to be consistent with other 3rd party extensions.

When I haven't opened addy in a new tab, yet it looks gray - on bright mode it looks pretty nice:

image

But in dark mode the gray seems to be a bit off in comparison to default icons:

image

  • Perhaps it could also be this pink by default like the others?

When I click on it, it gets colored, but in white mode it looks different than others:

image

On a dark header bar / in dark mode it looks consistent to others:

image

@marcolaux
Copy link
Author

marcolaux commented Oct 9, 2024

another example on a "bright" background
image

@Stjin
Copy link
Member

Stjin commented Oct 9, 2024

Aha, hmm. I will look into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants