Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed ansible tasks are written to cache #226

Open
kpcyrd opened this issue May 12, 2020 · 8 comments
Open

Failed ansible tasks are written to cache #226

kpcyrd opened this issue May 12, 2020 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@kpcyrd
Copy link

kpcyrd commented May 12, 2020

I ran a role that failed (user couldn't be created because a variable wasn't set), but when re-running ansible-bender build, the step after that failed because the user didn't exist.

It seems the layer of the failed task is still written to cache and ansible-bender picks up at the first missing layer and continues the build. I assume re-running the build command often enough is eventually going to result in ansible-bender build exiting successfully.

@TomasTomecek
Copy link
Collaborator

Well, caching is really just optimization, so the easiest thing to do is to just disable it and build fresh all the time.

It seems the layer of the failed task is still written to cache

This is really interesting, need to look into it and ideally reproduce locally.

Thanks for taking time to open this.

@TomasTomecek TomasTomecek added the bug Something isn't working label Jun 1, 2020
@TomasTomecek TomasTomecek self-assigned this Jan 8, 2021
@TomasTomecek
Copy link
Collaborator

Sadly I can't reproduce, I tried three forms of invoking roles and when the role failed, nothing was written to the cache, see a PR referencing this.

@mtvjr
Copy link

mtvjr commented Aug 11, 2021

Is there any update on this issue? I'm experiencing the same bug.

@TomasTomecek
Copy link
Collaborator

I'd appreciate a minimal reproducer since I wasn't able to reproduce myself.

@TomasTomecek
Copy link
Collaborator

oh, actually there is a PR already which should fix this - it just needs to be finished

@mtvjr
Copy link

mtvjr commented Aug 16, 2021

I'll see what I can do. Do you have an ETA on when the PR might be pulled in?

@TomasTomecek
Copy link
Collaborator

@mtvjr hard to say, I no longer have time to be involved in this project in a timely manner, hence my sporadic replies for the past few months

If I have time, I'd love to finish it which can easily take me weeks. If someone from the community, or the author of the PR, would be interested in finishing the work, that would be a huge help.

@mtvjr
Copy link

mtvjr commented Aug 20, 2021

I understand the difficulties of devoting time to a project.

Unfortunately, despite my best efforts, I can't come up with a repeatable minimum example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants