Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Natural Emissions Error in Python FAIR. #4

Open
FrankErrickson opened this issue Oct 2, 2021 · 0 comments
Open

Natural Emissions Error in Python FAIR. #4

FrankErrickson opened this issue Oct 2, 2021 · 0 comments
Labels
bug Something isn't working question Further information is requested

Comments

@FrankErrickson
Copy link
Collaborator

In the methane and nitrous oxide gas cycles in Python-FAIRv1.6.2, natural emissions in the current period are added to anthropogenic emissions for both the current and previous period. See the pasted Python code below or the actual FAIR repository code:

C[t,2] = emis_to_conc(
             C[t-1,2],
             emissions[t-1,4]+natural[t,1], 
             emissions[t,4]+natural[t,1],
             1.0,
             lifetimes[2],
             1.0/emis2conc[2]
             )

The Julia implementation of FAIRv.1.6.2 currently replicates this behavior. But it should be sorted out whether to fix this or keep it to match the Python version. In reality it probably doesn't make a huge difference under the default scenarios because natural emissions remain fixed after a certain period. But it could matter for other natural emission trajectories.

@FrankErrickson FrankErrickson added bug Something isn't working question Further information is requested labels Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant