-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project does not load with 1.19.3 #595
Comments
I also suffer from this problem after I upgraded the antlr plugin and installed my own plugin. And I thought there was something wrong with my plugin 🤣 |
hi! @gonozalviii @imkiva can you folks tell me what operating system, jetbrains tool (and version), and java version you have installed? |
I also hit this problem. I think almost any 2022.3 (EAP) IDEs have affected this problem.
|
Thanks for the quick reply! This is my local configuration.
|
I also run the EAP Version ` Runtime version: 17.0.5+1-b653.14 amd64 |
Thanks...i am rebuilding using intel jdk 11 (though I'm on apple silicon). Also making sure I have latest gradle. Will try on EAP though that might be an issue... |
Weird. Can't get 2022.3 to run (updated to jdk 17): oh. i think that is the upcoming release. |
yep, doesn't work with 2022.3. I'll have to add a limit on plugin version until I can track it down. |
Unfortunately, the 1.9.3 version is still installed by default, no the 1.9.3-1 version, so if you update or install this into the EAP, projects fail to load. I wonder if there is any way to patch the 1.9.3 version in place? |
I wonder if it's the intellij api change. we went from 1.6 to 1.10! maybe i back that down and see? |
I'm seeing the same thing. in Intellij 2022.3 release candidate, software version: version IntelliJ IDEA 2022.3 RC (Ultimate Edition) Non-Bundled Plugins: Kotlin: 223-1.7.20-release-201-IJ7571.58 |
damn. Let me try backing down the api version. |
Unfortunately backing down the API version doesn't work. It still feels to load with 2022.3. It should not allow you to actually load it though... I just got the warning that that plugin version it's not compatible. Did you load 1.19.3-1 or 1.19.3? @greenhull |
the one I'm seeing is 1.19.3, I'll uninstall and reinstall it and let you know. |
I think that one will tell you that it doesn't work and won't let you load it. sorry. Hopefully when it goes "live" 2022.3 will work. I can check it then. The reality is I already work seven days a week maintaining Open source software in addition to my job so this one may go down and priority as I work on lab.antlr.org |
No way to back off the last release of Antlr V4 plugin? |
oh. Maybe the previous version 1.18 will work yes. try it! |
how do I load it? |
Maybe download it from intellij plugins web and install from the disk? |
I'll give it try, thanks |
Here's what I found, if you download Antl V4 1.19.2 from: https://plugins.jetbrains.com/plugin/7358-antlr-v4/versions and do an install from disk, it works (after doing an antlr V4 uninstall) |
ok, good to know. That will give me some ammunition to look for differences... There should not be many changes so I'm surprised 1.19.3 doesn't work. If you have time to look at the differences that would be a big help... |
It seems the only change related to initialization is here: 1.19.2...1.19.3#diff-aa2e7919b16b9fc2dcf48d797342388c37bc7f7ff518718ca1f3404129f2b846R118-R127 In main branch: intellij-plugin-v4/src/main/java/org/antlr/intellij/plugin/ANTLRv4PluginController.java Lines 117 to 127 in 81b03b4
|
I can confirm that this is the code, that breaks the loading. I'm not sure why it is there, since the filetype is associated in the plugin.xml. EDIT: I found the ticket, that this is supposed to be a forced reasssign of the file extentions, if it was assigned before. |
Also, moving this code out of |
amazing, @gonozalviii !!! thanks. i'll try to push another release |
Hi. i uploaded 1.19.3-3 https://plugins.jetbrains.com/plugin/7358-antlr-v4 could you try it out? seems to work! @gonozalviii @imkiva thanks! |
Hmm...many tests fail now:
Can't imagine that backout was the cause. |
It seems to work, Thanks |
cool. can't figure out why tests are failing though. ugh. |
This is the ticket where I'm waiting for the real fix |
possible same problem or new: exception in Antlr V4 1.19.3-3. stacktrace: Intellij Info: IntelliJ IDEA 2022.3 RC (Ultimate Edition) Non-Bundled Plugins: Kotlin: 223-1.7.20-release-201-IJ7571.123 |
dang! That looks like a new issue. |
I am not having the same problems as OP as my project still loads, but my ANTLR plugin (1.19.3-3) just threw a NPE with a similar stack trace to what @greenhull just posted. I am using Rider 2022.2.4 (build #RD-222.4459.9).
|
Hi. Could you open a separate bug for this? Anything weird with your setup? Empty files? Weird file names? Can you give a sample grammar and sequence to reproduce? Thanks! |
@geoff-m and @greenhull your issue is the same as #611, which was fixed today and will be released in version 1.20 of the plugin. |
So, from what I understand the original problem was caused by the fix for #569, which has been reverted and a new version 1.19.3-3 was released to address this problem. I guess this ticket can be closed then. |
I just updated the plugin to version 1.19.3 and after the restart the project gets stuck in the loading bar. Downgrading or disabeling the plugins solves the Problem.
The text was updated successfully, but these errors were encountered: