Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionUpdateThread.OLD_EDT is deprecated and going to be removed soon #696

Closed
bjansen opened this issue Mar 9, 2024 · 9 comments
Closed
Milestone

Comments

@bjansen
Copy link
Collaborator

bjansen commented Mar 9, 2024

com.intellij.diagnostic.PluginException: `ActionUpdateThread.OLD_EDT` is deprecated and going to be removed soon. 'org.antlr.intellij.plugin.actions.ConfigureANTLRAction' must override `getActionUpdateThread` and chose EDT or BGT. See ActionUpdateThread javadoc. [Plugin: org.antlr.intellij.plugin]
	at com.intellij.diagnostic.PluginProblemReporterImpl.createPluginExceptionByClass(PluginProblemReporterImpl.java:23)
	at com.intellij.diagnostic.PluginException.createByClass(PluginException.java:90)
	at com.intellij.diagnostic.PluginException.reportDeprecatedUsage(PluginException.java:125)
	at com.intellij.openapi.actionSystem.ActionUpdateThreadAware.getActionUpdateThread(ActionUpdateThreadAware.java:21)
	at com.intellij.openapi.actionSystem.AnAction.getActionUpdateThread(AnAction.java:199)

@oovm
Copy link

oovm commented Mar 11, 2024

I have the same error, all my highlights are invalid

@bjansen
Copy link
Collaborator Author

bjansen commented Mar 11, 2024

@oovm I think the two problems are unrelated. I fixed syntax highlighting in 2024.1 EAP and published a new version 1.23.1. Could you try it and see if it fixes your highlighting problem?

@oovm
Copy link

oovm commented Mar 11, 2024

It should be that an exception was thrown that interrupted lexer's lexical highlighting. After the update, antlr highlighting returned to normal.

@yaohwu
Copy link

yaohwu commented Apr 19, 2024

image same happened in 1.23.1 plugin and IntelliJ IDEA 2024.1 (Ultimate Edition)

@447491480
Copy link

same error
image

@bwinters
Copy link

some additional info from IntelliJ idea.log:

ANTLR 4 Plugin version 1.23.1, Java version 21.0.3
IntelliJ IDEA 2024.2 Build #IU-242.20224.300
JDK: 21.0.3; VM: OpenJDK 64-Bit Server VM
OS: Windows Server 2022

getting the message for

  • org.antlr.intellij.plugin.actions.GenerateParserAction
  • org.antlr.intellij.plugin.actions.ConfigureANTLRAction
  • org.antlr.intellij.plugin.actions.TestRuleAction
  • org.antlr.intellij.plugin.actions.GenerateLexerRulesForLiteralsAction

@swnck
Copy link

swnck commented Oct 4, 2024

Please release the current 1.23.2 because nothing works with the current 1.23.1 version.

@bjansen
Copy link
Collaborator Author

bjansen commented Oct 5, 2024

@swnck what's not working in your case? The message above is just a warning and afaik does not prevent anything from working as expected. Besides, I haven't finished fixing the problem entirely, so releasing the current version would not solve anything.

bjansen added a commit that referenced this issue Oct 6, 2024
@bjansen bjansen closed this as completed Oct 6, 2024
@lppedd
Copy link

lppedd commented Oct 6, 2024

Thanks for pushing the new version! I'm not seeing the EDT messages anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants