Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 增加Pictorial组件 #1967

Merged
merged 2 commits into from
May 28, 2024
Merged

feat: 增加Pictorial组件 #1967

merged 2 commits into from
May 28, 2024

Conversation

tangying1027
Copy link
Contributor

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

@tangying1027 tangying1027 requested a review from zengyue May 28, 2024 07:07
Copy link

github-actions bot commented May 28, 2024

Fails
🚫

node failed.

Log

Error:  ReferenceError: Cannot access 'artifact' before initialization
    at dangerfile.js:29:9
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
danger-results://tmp/danger-results-53bcdb70.json

Generated by 🚫 dangerJS against 3f4c37a

fillOpacity: 0.9,
}}
/>
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个的使用方式有点奇怪,可以用 () => VNode 这种方式

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<Pictorial
  x="x"
  y="value"
  symbol={
    ({ xMin, xMax, yMin, yMax }) => {
      return (
        <rect
            style={{
              x: xMin,
              y: yMin,
              width: xMax - xMin,
              height: yMax - yMin,
              fill: 'l(90) 0:#9cc1ff 1:#ecf5ff',
              fillOpacity: 0.9,
            }}
          />
    )
    }
    
  }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

@zengyue zengyue merged commit 6a6b226 into v5.0.x May 28, 2024
8 of 10 checks passed
@zengyue zengyue deleted the feat-Pictorial branch May 28, 2024 12:19
tangying1027 added a commit that referenced this pull request May 29, 2024
* feat: 增加Pictorial组件

* fix: 修改api

---------

Co-authored-by: xuying.xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants