Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@antv/s2-vue SheetComponent 的 loading 属性失效 #2922

Open
minikinl opened this issue Oct 12, 2024 · 3 comments
Open

@antv/s2-vue SheetComponent 的 loading 属性失效 #2922

minikinl opened this issue Oct 12, 2024 · 3 comments
Labels
💤 inactive 不活跃的 Issue 或 PR, 30天没有回复 next 2.0-next 版本的问题

Comments

@minikinl
Copy link

版本依赖

  • @antv/s2: 2.0.0-next.28
  • @antv/s2-vue: 2.0.0-next.15
  • vue: 3.2.41
  • ant-design-vue: 3.2.13

问题描述

更新 loading 状态未显示加载状态

问题排查

vue setup 中的 hook 区别于 react,仅在组件创建时执行一次,直接解构 props 会导致失去响应性。

建议使用以下方式解构,或直接 watch props.loading 并更新 loading 状态。

const { ... } = toRefs(props); 

目前只发现 loading 不生效,其余功能待进一步测试,但看源码应该是存在问题的。

Copy link
Contributor

你好 @minikinl,请按照 issue 模板填写相关信息, 方便大家高效沟通, 强烈推荐你阅读 提 Issue 前必读如何向开源项目提交无法解答的问题

Hello @minikinl, please fill in the relevant information according to the issue template to facilitate communication efficiently. recommend you to read 提 Issue 前必读 and 如何向开源项目提交无法解答的问题, Thanks so much!

@github-actions github-actions bot added the ⛔ invalid issue 什么描述都没写 label Oct 12, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2024
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Oct 12, 2024
@lijinke666 lijinke666 reopened this Oct 12, 2024
@lijinke666 lijinke666 removed the ⛔ invalid issue 什么描述都没写 label Oct 12, 2024
@lijinke666
Copy link
Member

直接来个 PR?

@minikinl
Copy link
Author

sry 我是直接从源码页发起的 issue,没有注意到 issue 模板~

有空的时候会再继续跟进hh

@github-actions github-actions bot added the 💤 inactive 不活跃的 Issue 或 PR, 30天没有回复 label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💤 inactive 不活跃的 Issue 或 PR, 30天没有回复 next 2.0-next 版本的问题
Projects
None yet
Development

No branches or pull requests

2 participants