Allow json_result_force_utf8_encoding specification in providers.snowflake.hooks.SnowflakeHook extra dict
#44264
+38
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:snowflake
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
ttzhou
commented
Nov 21, 2024
| @@ -323,6 +333,9 @@ def get_sqlalchemy_engine(self, engine_kwargs=None): | |||
| if "insecure_mode" in conn_params: | |||
| engine_kwargs.setdefault("connect_args", {}) | |||
| engine_kwargs["connect_args"]["insecure_mode"] = True | |||
| if "json_result_force_utf8_decoding" in conn_params: | |||
There was a problem hiding this comment.
I thought about lumping this together into the same branch on line 335 above, but wanted to reduce diff count for now. Happy to make that change as well if you prefer, since it's the same type of value.
…wflake-connector-argument
ttzhou
commented
Nov 21, 2024
| @@ -301,7 +307,13 @@ def _conn_params_to_sqlalchemy_uri(self, conn_params: dict) -> str: | |||
| for k, v in conn_params.items() | |||
| if v | |||
| and k | |||
| not in ["session_parameters", "insecure_mode", "private_key", "client_request_mfa_token"] | |||
| not in { | |||
There was a problem hiding this comment.
changed to a set; we're not iterating, may as well make it O(1)
…wflake-connector-argument
…wflake-connector-argument
…wflake-connector-argument
…wflake-connector-argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Justification:
Snowflake's Python connector recommends using
json_result_force_utf8_decodingtoTrue, but preserves it asFalse/no-op for legacy reasons. I've come across cases at work where not setting this returns unexpected results, whereas setting it to True (via a workaround) returns the expected results.Therefore, I think there is a valid case for allowing this to be passed via connection arguments (via
extra).Relevant 'upstream' Snowflake connector code
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.