Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question around fixed hierarchy for schema #46

Open
GavinRay97 opened this issue Jul 25, 2022 · 2 comments
Open

Question around fixed hierarchy for schema #46

GavinRay97 opened this issue Jul 25, 2022 · 2 comments

Comments

@GavinRay97
Copy link

I noticed that the ADBC metadata information assumes a fixed hierarchy:

* Get a hierarchical view of all catalogs, database schemas, tables, and columns.

What would the advice be for datasources that don't fit this, like Snowflake/Trino/Dremio where the hierarchy might be:

  • datasource.database.schema.table
  • postgres1.mydb.public.emps
@lidavidm
Copy link
Member

Hmm, real-world edge cases are always fun, thanks for poking around. (Admittedly we should've looked more closely at these.)

We were debating whether to keep the hierarchy or split it into multiple views (akin to Flight SQL), so this might be an argument for splitting them.

Do you have a reference for the Snowflake/Trino behavior? I see examples like the following that document three levels of hierarchy, but not the fourth level:

https://trino.io/docs/current/connector/postgresql.html#querying-postgresql
https://docs.snowflake.com/en/user-guide/databases.html

@lidavidm
Copy link
Member

lidavidm commented Jan 6, 2023

A few people are plotting out an ADBC 1.1.0 API specification already. In #320 I put up a quick solution to this, based on what we talked about before (letting db_schema have a delimiter).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants