New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK Optimization] Multiple SimpleDateFormat initialization in CarbonReader #4281

Open

zhangboren93 opened this issue Jun 22, 2022 · 1 comment

zhangboren93 commented Jun 22, 2022

I found that reading carbon files from CarbonReader takes long time in "SimpleDateFormat.", see attached file for output of
profiling.

carbondata/sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReader.java

Line 207 in 4b8846d

SimpleDateFormat dateFormat = new SimpleDateFormat(carbonDateFormat);

I wonder if it is OK if we add some lazy initialization to SimpleDateFormat in the class, and if so should it support multi-threading.

prajwalbandak commented Aug 20, 2023

hey @zhangboren93 , Can you please assign to me and please explain the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment