From 533b6b9520fbd0b926dd867840822302faed65b7 Mon Sep 17 00:00:00 2001 From: Jon Malkin <786705+jmalkin@users.noreply.github.com> Date: Wed, 14 Aug 2024 00:12:07 -0700 Subject: [PATCH] use .sk suffix on cross-lang filter binaries to avoid workflow changes --- filters/test/bloom_filter_deserialize_from_java_test.cpp | 2 +- filters/test/bloom_filter_serialize_for_java.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/filters/test/bloom_filter_deserialize_from_java_test.cpp b/filters/test/bloom_filter_deserialize_from_java_test.cpp index 255d1f78..f2dee18c 100644 --- a/filters/test/bloom_filter_deserialize_from_java_test.cpp +++ b/filters/test/bloom_filter_deserialize_from_java_test.cpp @@ -35,7 +35,7 @@ TEST_CASE("bloom_filter", "[serde_compat]") { for (const uint16_t num_hashes: h_arr) { std::ifstream is; is.exceptions(std::ios::failbit | std::ios::badbit); - is.open(testBinaryInputPath + "bf_n" + std::to_string(n) + "_h" + std::to_string(num_hashes) + "_cpp.filter", std::ios::binary); + is.open(testBinaryInputPath + "bf_n" + std::to_string(n) + "_h" + std::to_string(num_hashes) + "_cpp.sk", std::ios::binary); auto bf = bloom_filter::deserialize(is); REQUIRE(bf.is_empty() == (n == 0)); REQUIRE((bf.is_empty() || (bf.get_bits_used() > n / 10))); diff --git a/filters/test/bloom_filter_serialize_for_java.cpp b/filters/test/bloom_filter_serialize_for_java.cpp index 082e5b2a..be4e62b1 100644 --- a/filters/test/bloom_filter_serialize_for_java.cpp +++ b/filters/test/bloom_filter_serialize_for_java.cpp @@ -36,7 +36,7 @@ TEST_CASE("bloom filter generate", "[serialize_for_java]") { if (n > 0) bf.update(std::nan("1")); // include a NaN if non-empty REQUIRE(bf.is_empty() == (n == 0)); REQUIRE((bf.is_empty() || (bf.get_bits_used() > n / 10))); - std::ofstream os("bf_n" + std::to_string(n) + "_h" + std::to_string(num_hashes) + "_cpp.filter", std::ios::binary); + std::ofstream os("bf_n" + std::to_string(n) + "_h" + std::to_string(num_hashes) + "_cpp.sk", std::ios::binary); bf.serialize(os); } }