Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Java sdk split multiple sdk by communication protocol #1013

Closed
1 of 2 tasks
mytang0 opened this issue Jul 11, 2022 · 5 comments
Closed
1 of 2 tasks

[Enhancement] Java sdk split multiple sdk by communication protocol #1013

mytang0 opened this issue Jul 11, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mytang0
Copy link
Member

mytang0 commented Jul 11, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

Java sdk split multiple sdk by communication protocol, implement the slimming of the java sdk.

Describe the solution you'd like

Java sdk split multiple sdk by communication protocol.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@mytang0 mytang0 added the enhancement New feature or request label Jul 11, 2022
@github-actions
Copy link
Contributor

Welcome to the Apache EventMesh (incubating) community!!
We are glad that you are contributing by opening this issue. :D

Please make sure to include all the relevant context.
We will be here shortly.

If you are interested in contributing to our project, please let us know!
You can check out our contributing guide on contributing to EventMesh.

Want to get closer to the community?

WeChat Group:
wechat_qr

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives

@Pil0tXia Pil0tXia added the help wanted Extra attention is needed label Jan 19, 2024
@scwlkq
Copy link
Contributor

scwlkq commented Jan 23, 2024

@Pil0tXia Is it still necessary to implement this issue in the current version? If there is one, I would like to give it a try.

@scwlkq
Copy link
Contributor

scwlkq commented Jan 24, 2024

@qqeasonchen @mytang0 Is it still necessary to implement this issue in the current version? If there is one, I would like to give it a try.

@qqeasonchen
Copy link
Contributor

In #4759 , we do not think this is the best time to do, I will close it now, we will reopen it until we think it is necessary to do this, thank you for you suggestions.

@qqeasonchen qqeasonchen closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2024
@scwlkq
Copy link
Contributor

scwlkq commented Feb 1, 2024

In #4759 , we do not think this is the best time to do, I will close it now, we will reopen it until we think it is necessary to do this, thank you for you suggestions.

I get that. But in this issue, i found that the EventMeshCommon class in the original TCP package was referenced by the classes of grpc, HTTP, and other modules. So should I placed this class under the Common module and corrected the reference? This also eliminates the coupling between the modules of the Java SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants