Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the Antlr4 Maven Plugin version and bump the minimum JDK compilation level to JDK11 #7036

Closed
linghengqian opened this issue Nov 30, 2024 · 3 comments

Comments

@linghengqian
Copy link
Member

linghengqian commented Nov 30, 2024

Why you need it?

Is your feature request related to a problem? Please describe in details

      <dependency>
         <groupId>org.apache.seata</groupId>
         <artifactId>seata-all</artifactId>
         <version>2.2.0</version>
         <exclusions>
            <exclusion>
               <groupId>org.antlr</groupId>
               <artifactId>antlr4-runtime</artifactId>
            </exclusion>
         </exclusions>
      </dependency>

How it could be?

A clear and concise description of what you want to happen. You can explain more about input of the feature, and output of it.

  • Long story short, I expect Seata Client to update the version of org.antlr:antlr4 from 4.8 to 4.10.1. This necessarily means raising the minimum JDK compilation level for compiling Seata to JDK11.
  • org.antlr:antlr4-maven-plugin:4.10.1 requires JDK 11, but org.antlr:antlr4-runtime:4.10.1 still works on JDK 8. So I don't think this is likely to affect downstream users using JDK8, only developers need to use JDK11+ to compile Seata. See https://lists.apache.org/thread/kgtfx5vnw73o61lkvdshyfvjfvvzk3js .
  • Or another possibility is to remove the use of Antlr4. I noticed that Seata actually uses Alibaba Druid parsing dialect and does not use Antlr4 at all.

Other related information

Add any other context or screenshots about the feature request here.

@funky-eyes
Copy link
Contributor

Actually, as you mentioned, ANTLR is currently just a supplementary solution and not the default SQL parsing method. Therefore, theoretically, on the ShardingSphere side, we can directly exclude this dependency to resolve the issue.

@linghengqian
Copy link
Member Author

No problem. Should I just close the issue?

@funky-eyes
Copy link
Contributor

I think this issue can be closed

@linghengqian linghengqian closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants