You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the source, ShardingSphere uses Maven Plugin of org.antlr:antlr4-maven-plugin:4.10.1 to compile *.g4 files, while org.antlr:antlr4-runtime:4.8 used by org.apache.seata:seata-all:2.2.0 obviously cannot read the binary of org.antlr:antlr4-maven-plugin:4.10.1.
A clear and concise description of what you want to happen. You can explain more about input of the feature, and output of it.
Long story short, I expect Seata Client to update the version of org.antlr:antlr4 from 4.8 to 4.10.1. This necessarily means raising the minimum JDK compilation level for compiling Seata to JDK11.
org.antlr:antlr4-maven-plugin:4.10.1 requires JDK 11, but org.antlr:antlr4-runtime:4.10.1 still works on JDK 8. So I don't think this is likely to affect downstream users using JDK8, only developers need to use JDK11+ to compile Seata. See https://lists.apache.org/thread/kgtfx5vnw73o61lkvdshyfvjfvvzk3js .
Or another possibility is to remove the use of Antlr4. I noticed that Seata actually uses Alibaba Druid parsing dialect and does not use Antlr4 at all.
Other related information
Add any other context or screenshots about the feature request here.
Actually, as you mentioned, ANTLR is currently just a supplementary solution and not the default SQL parsing method. Therefore, theoretically, on the ShardingSphere side, we can directly exclude this dependency to resolve the issue.
Why you need it?
Is your feature request related to a problem? Please describe in details
org.antlr:antlr4:4.8
when writing downstream documents like https://shardingsphere.apache.org/document/current/cn/user-manual/shardingsphere-jdbc/special-api/transaction/seata/ and https://www.yuque.com/linghengqian/meve2v/es8d3a8a18odao7x .org.antlr:antlr4-maven-plugin:4.10.1
to compile*.g4
files, whileorg.antlr:antlr4-runtime:4.8
used byorg.apache.seata:seata-all:2.2.0
obviously cannot read the binary oforg.antlr:antlr4-maven-plugin:4.10.1
.How it could be?
A clear and concise description of what you want to happen. You can explain more about input of the feature, and output of it.
org.antlr:antlr4
from4.8
to4.10.1
. This necessarily means raising the minimum JDK compilation level for compiling Seata to JDK11.org.antlr:antlr4-maven-plugin:4.10.1
requires JDK 11, butorg.antlr:antlr4-runtime:4.10.1
still works on JDK 8. So I don't think this is likely to affect downstream users using JDK8, only developers need to use JDK11+ to compile Seata. See https://lists.apache.org/thread/kgtfx5vnw73o61lkvdshyfvjfvvzk3js .Other related information
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: