Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Dependabot from suggesting dependency updates for Jackson #1396

Closed
jnioche opened this issue Nov 4, 2024 · 2 comments · Fixed by #1433
Closed

Prevent Dependabot from suggesting dependency updates for Jackson #1396

jnioche opened this issue Nov 4, 2024 · 2 comments · Fixed by #1433

Comments

@jnioche
Copy link
Contributor

jnioche commented Nov 4, 2024

We need to use whatever Storm uses, which is not necessarily the latestt

See #1391 (comment)
@jnioche jnioche mentioned this issue Nov 4, 2024
Closed
@rzo1
Copy link
Contributor

rzo1 commented Nov 15, 2024

Here is an example: https://github.com/apache/shiro/blob/main/.github/dependabot.yml

@dave2wave
Copy link
Member

2.17.3 was released 2 days after 2.18.1 about 2 weeks ago.

Should StormCrawler stay on the exact same version or the same line? EG. Storm is on 2.17.2 while SC is 2.17.3?

jnioche added a commit that referenced this issue Dec 2, 2024
@jnioche
Prevent Dependabot from suggesting dependency updates for Jackson, fixes
0473605 
 #1396

Signed-off-by: Julien Nioche <[email protected]>
@jnioche jnioche mentioned this issue Dec 2, 2024
Merged
@rzo1 rzo1 closed this as completed in #1433 Dec 2, 2024
@rzo1 rzo1 closed this as completed in ab4ffb3 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent Dependabot from suggesting dependency updates for Jackson apache/incubator-stormcrawler
3 participants
@jnioche @rzo1 @dave2wave