Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2207] feat(dashboard): Add the write information of appinfo in Shuflle Server heartbeat #2208

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

lwllvyb
Copy link
Contributor

@lwllvyb lwllvyb commented Oct 19, 2024

What changes were proposed in this pull request?

Add the write information of appinfo in Shuflle Server heartbeat

Why are the changes needed?

Fix: #2207

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Locally

Copy link

Test Results

 2 926 files  +31   2 926 suites  +31   5h 57m 13s ⏱️ + 10m 8s
 1 043 tests ± 0   1 041 ✅ + 1   2 💤 ±0  0 ❌  - 1 
13 033 runs  +60  13 003 ✅ +61  30 💤 ±0  0 ❌  - 1 

Results for commit 9c62de9. ± Comparison against base commit f9b4c0e.

Copy link
Member

@maobaolong maobaolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@maobaolong
Copy link
Member

maobaolong commented Oct 21, 2024

@lwllvyb It would be easy to understand your changes if you could use the curl http://localhost:19976/api/app/appInfos | python -m json.tool to query the appInfos and paste it to the description.

Or another way to show how to get the appInfo from the coordinator after this PR?

@jerqi jerqi changed the title feature[dashboard] Add the write information of appinfo in Shuflle Server heartbeat feature(dashboard): Add the write information of appinfo in Shuflle Server heartbeat Oct 21, 2024
@lwllvyb
Copy link
Contributor Author

lwllvyb commented Oct 21, 2024

@lwllvyb It would be easy to understand your changes if you could use the curl http://localhost:19976/api/app/appInfos | python -m json.tool to query the appInfos and paste it to the description.

Or another way to show how to get the appInfo from the coordinator after this PR?

@lwllvyb It would be easy to understand your changes if you could use the curl http://localhost:19976/api/app/appInfos | python -m json.tool to query the appInfos and paste it to the description.

Or another way to show how to get the appInfo from the coordinator after this PR?

This PR is derived from another PR #2063 . I split the PR #2063 into several smaller PRs that are easier to review, and this one of them.

I will commit another PR #2215 (I have created an issue #2211 ) which depends on this PR. I don't know if this is the right approach.

After submitting the PR related to #2211, the dashboard will show the application info as follows.

image

@jerqi jerqi changed the title feature(dashboard): Add the write information of appinfo in Shuflle Server heartbeat [#2207] feat(dashboard): Add the write information of appinfo in Shuflle Server heartbeat Oct 21, 2024
@jerqi jerqi merged commit 3a35b0f into apache:master Oct 21, 2024
43 checks passed
jerqi pushed a commit that referenced this pull request Oct 23, 2024
…in dashboard (#2215)

### What changes were proposed in this pull request?

Display the write information of application in dashboard

### Why are the changes needed?

Fix: #2211 

### Does this PR introduce _any_ user-facing change?

Yes.

![image](https://github.com/user-attachments/assets/ea88f195-ffdf-46c4-af2c-045c3bb338c6)


### How was this patch tested?

Tested locally.

Related PR: #2208 

Co-authored-by: wenlongwlli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add the write information of appinfo in Shuflle Server heartbeat
3 participants