-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2207] feat(dashboard): Add the write information of appinfo in Shuflle Server heartbeat #2208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM
@lwllvyb It would be easy to understand your changes if you could use the Or another way to show how to get the appInfo from the coordinator after this PR? |
This PR is derived from another PR #2063 . I split the PR #2063 into several smaller PRs that are easier to review, and this one of them. I will commit another PR #2215 (I have created an issue #2211 ) which depends on this PR. I don't know if this is the right approach. After submitting the PR related to #2211, the dashboard will show the application info as follows. |
…in dashboard (#2215) ### What changes were proposed in this pull request? Display the write information of application in dashboard ### Why are the changes needed? Fix: #2211 ### Does this PR introduce _any_ user-facing change? Yes. ![image](https://github.com/user-attachments/assets/ea88f195-ffdf-46c4-af2c-045c3bb338c6) ### How was this patch tested? Tested locally. Related PR: #2208 Co-authored-by: wenlongwlli <[email protected]>
What changes were proposed in this pull request?
Add the write information of appinfo in Shuflle Server heartbeat
Why are the changes needed?
Fix: #2207
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Locally