Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR] improvement(ci): add some examples and notice #2240

Merged
merged 2 commits into from
Nov 11, 2024
Merged

[MINOR] improvement(ci): add some examples and notice #2240

merged 2 commits into from
Nov 11, 2024

Conversation

maobaolong
Copy link
Member

What changes were proposed in this pull request?

add some examples and notice

Why are the changes needed?

  • To show more use case about how to write PR title
  • Notice contributors to remove all the generated comments before review request.

@maobaolong
Copy link
Member Author

@zuston @jerqi Would you like to take a look at this PR template improvement? Thanks.

@maobaolong maobaolong mentioned this pull request Nov 7, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

Test Results

 2 941 files  ±0   2 941 suites  ±0   6h 16m 57s ⏱️ + 6m 18s
 1 091 tests ±0   1 089 ✅ ±0   2 💤 ±0  0 ❌ ±0 
13 670 runs  ±0  13 640 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit 7c7743a. ± Comparison against base commit 051a247.

♻️ This comment has been updated with latest results.

@maobaolong
Copy link
Member Author

@jerqi @zuston Let's discuss the style here.

After search the log history by regex, i found that

  • (A,B) : 6 commits
image
  • (A/B): 10+ commits
image
  • (A)(B): 8+ commits
image

zuston
zuston previously approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@zuston zuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@maobaolong
Copy link
Member Author

@jerqi How about your idea?

@jerqi
Copy link
Contributor

jerqi commented Nov 8, 2024 •
edited
Loading

lgtm.

Which projects adopt (server)(client) style?
It seems more common to use the style (server,client).

@maobaolong
Copy link
Member Author

maobaolong commented Nov 8, 2024 •
edited
Loading

@jerqi OK, I updated it to (server,client)

@maobaolong
Copy link
Member Author

@jerqi Thanks for your review, merge it

@maobaolong maobaolong merged commit 77c5c61 into apache:master Nov 11, 2024
43 checks passed
maobaolong added a commit to maobaolong/incubator-uniffle that referenced this pull request Nov 21, 2024
@maobaolong @kuszz
[MINOR] improvement(ci): add some examples and notice (apache#2240)
79eda56 
### What changes were proposed in this pull request?

add some examples and notice

### Why are the changes needed?

- To show more use case about how to write PR title
- Notice contributors to remove all the generated comments before review request.

(cherry picked from commit 77c5c61)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerqi jerqi jerqi approved these changes

@zuston zuston zuston left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maobaolong @jerqi @zuston