Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2261]: feat(Coordinator): Introduce banned id manager and checker #2255

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

maobaolong
Copy link
Member

@maobaolong maobaolong commented Nov 18, 2024

What changes were proposed in this pull request?

Introduce banned id manager and checker

Why are the changes needed?

Provide a common way to banned an app to fallback to SORT shuffle manager.

The app id can be extracted from a specific spark conf.

Fix: #2261

Does this PR introduce any user-facing change?

$  curl -X POST http://localhost:19998/banned/reload \
-H "Content-Type: application/json" \
-d '{"version": "v1.0", "ids": ["123", "456", "789"]}'

{"code":0,"data":"success","errMsg":"success"}%                                                                                                                                                                                                                                                                                                                           

$  curl http://localhost:19998/banned/version

{"code":0,"data":"v1.0","errMsg":"success"}%

How was this patch tested?

New added UT.

Copy link

github-actions bot commented Nov 18, 2024

Test Results

 2 971 files  +15   2 971 suites  +15   6h 28m 13s ⏱️ ±0s
 1 094 tests + 2   1 092 ✅ + 2   2 💤 ±0  0 ❌ ±0 
13 715 runs  +30  13 685 ✅ +30  30 💤 ±0  0 ❌ ±0 

Results for commit ea1f3b0. ± Comparison against base commit 99eaa9d.

♻️ This comment has been updated with latest results.

@zuston
Copy link
Member

zuston commented Nov 19, 2024

Thanks for proposing this, I think I will review this in next days.

@jerqi
Copy link
Contributor

jerqi commented Nov 25, 2024

You would better create an issue for a feature or a bug.

@maobaolong maobaolong changed the title [MINOR]: feat(Coordinator): Introduce banned id manager and checker [#2261]: feat(Coordinator): Introduce banned id manager and checker Nov 25, 2024
@maobaolong
Copy link
Member Author

@jerqi Thank you for remind me this, I created an issue mark it as a feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Introduce a common BannedManager to ban the found bad application
3 participants