KNOX-3042 - Correct KnoxToken comparator #918
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bonampak - could you add a unit test for this to clearly show what the failure was and that it is fixed and doesn't regress? Sorry for the delayed review here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Correct KnoxToken comparator so that TokenStateService.fetchTokens() would return all the tokens, even if their issue time is the same. If two tokens have the same issue time, then one with the smaller token id (uuid) will be revoked.
How was this patch tested?
So far only the existing tests are run and we could add a revocation test to TokenServiceResourceTest.