[KYUUBI #6790] Fix engine cannot exit when gracefully stopped #6792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
approved these changes
Nov 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6792 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 687 687
Lines 42441 42442 +1
Branches 5793 5793
======================================
- Misses 42441 42442 +1 ☔ View full report in Codecov by Sentry. |
turboFei
pushed a commit
that referenced
this pull request
Nov 5, 2024
# 🔍 Description ## Issue References 🔗 Fix engine cannot exit when gracefully stopped This pull request fixes #6790 ## Describe Your Solution 🔧 ## Types of changes 🔖 - [X] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [X] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6792 from wForget/KYUUBI-6790. Closes #6790 efe7a2f [wforget] [KYUUBI-6790] Fix engine cannot exit when gracefully stopped Authored-by: wforget <[email protected]> Signed-off-by: Wang, Fei <[email protected]> (cherry picked from commit b4838b4) Signed-off-by: Wang, Fei <[email protected]>
turboFei
pushed a commit
that referenced
this pull request
Nov 5, 2024
# 🔍 Description ## Issue References 🔗 Fix engine cannot exit when gracefully stopped This pull request fixes #6790 ## Describe Your Solution 🔧 ## Types of changes 🔖 - [X] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [X] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6792 from wForget/KYUUBI-6790. Closes #6790 efe7a2f [wforget] [KYUUBI-6790] Fix engine cannot exit when gracefully stopped Authored-by: wforget <[email protected]> Signed-off-by: Wang, Fei <[email protected]> (cherry picked from commit b4838b4) Signed-off-by: Wang, Fei <[email protected]>
|
thanks, merged to main/1.10/1.9/1.8.3 |
turboFei
pushed a commit
that referenced
this pull request
Nov 5, 2024
# 🔍 Description ## Issue References 🔗 Fix engine cannot exit when gracefully stopped This pull request fixes #6790 ## Describe Your Solution 🔧 ## Types of changes 🔖 - [X] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [X] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6792 from wForget/KYUUBI-6790. Closes #6790 efe7a2f [wforget] [KYUUBI-6790] Fix engine cannot exit when gracefully stopped Authored-by: wforget <[email protected]> Signed-off-by: Wang, Fei <[email protected]> (cherry picked from commit b4838b4) Signed-off-by: Wang, Fei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
Fix engine cannot exit when gracefully stopped
This pull request fixes #6790
Describe Your Solution 🔧
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.