Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWEEP: Rename BeforeClass/AfterClass to OneTimeSetUp/OneTimeTearDown, #1016 #1051

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

paulirwin
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Rename BeforeClass/AfterClass to OneTimeSetUp/OneTimeTearDown to better match NUnit conventions.

Fixes #1016

Description

See #1016 for details and rationale. This is a breaking change because of the changes in TestFramework.

@paulirwin paulirwin added the notes:breaking-change Has changes that will break backward compatibility label Nov 27, 2024
Copy link
Contributor

@NightOwl888 NightOwl888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

This looks good. However, I noticed during the review that some of the related documentation comments are incorrect or out of date. Those can either be fixed in this PR or a new issue, but I don't think it is important to update the API docs site for 4.8.0-beta00017 with these changes. In other words, they can be committed to master and we will roll them into the 4.8.0-beta00018 API docs.

src/Lucene.Net.TestFramework/Util/LuceneTestCase.cs Outdated Show resolved Hide resolved
src/Lucene.Net.Tests/Search/Spans/TestBasics.cs Outdated Show resolved Hide resolved
src/Lucene.Net.Tests/Search/TestBooleanMinShouldMatch.cs Outdated Show resolved Hide resolved
src/Lucene.Net.Tests/Search/TestNGramPhraseQuery.cs Outdated Show resolved Hide resolved
src/Lucene.Net.Tests/Search/TestNumericRangeQuery32.cs Outdated Show resolved Hide resolved
src/Lucene.Net.Tests/Search/TestNumericRangeQuery64.cs Outdated Show resolved Hide resolved
src/Lucene.Net.Tests/Search/TestPrefixInBooleanQuery.cs Outdated Show resolved Hide resolved
src/Lucene.Net.Tests/Search/TestTermVectors.cs Outdated Show resolved Hide resolved
@paulirwin paulirwin merged commit abe75de into apache:master Nov 27, 2024
197 checks passed
@paulirwin paulirwin deleted the issue/1016 branch November 27, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes:breaking-change Has changes that will break backward compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Rename BeforeClass() to OneTimeSetUp() and AfterClass() to OneTimeTearDown() to match NUnit Conventions
2 participants