Fix intermittent failed TestMaxClauseLimitations tests, #1050 #1054
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix intermittent failed TestMaxClauseLimitations tests
Fixes #1050
Description
These tests occasionally fail on .NET 8 due to Dynamic PGO optimizing the code and inlining some methods, which changes the stack trace. Instead of harming performance by forcing NoInlining, since this case inspecting the stack trace was only for an assertion rather than changing behavior (as other cases of inspecting the stack trace for specific methods do), this assertion was removed. It should only matter here if the exception is thrown; not which specific method throws it. The
Assert.Fail
above thiscatch
explains exactly that, and the original comment was even questioning whether it should be removed.