Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalizer fix #951

Merged
merged 7 commits into from
Aug 15, 2024
Merged

Finalizer fix #951

merged 7 commits into from
Aug 15, 2024

Conversation

stesee
Copy link
Contributor

@stesee stesee commented Jun 25, 2024

  • [/] You've read the Contributor Guide and Code of Conduct.
  • [/] You've included unit or integration tests for your change, where applicable.
  • [/] You've included inline docs for your change, where applicable.
  • [/] There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Fixes #950

Description

Dropped the finalizer in IndexReader

<InternalsVisibleTo Include="Lucene.Net.Tests.TestFramework" />
<InternalsVisibleTo Include="Lucene.Net.Tests.TestFramework.DependencyInjection" />
</ItemGroup>
<Import Project="$(SolutionDir).build/nuget.props" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO formatting should be done in a separate PR. But that said, we should have correct indentation settings for more file types in .editorconfig and default settings for unspecified files. 2 spaces for XML/JSON type files seems to be the standard.

Copy link
Contributor

@NightOwl888 NightOwl888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and your willingness to help make our project better.

There are a few changes we would like you to make before we can accept this PR. Please see the comments inline.

src/Lucene.Net/Index/IndexReader.cs Outdated Show resolved Hide resolved
NuGet.config Outdated Show resolved Hide resolved
src/Lucene.Net/Lucene.Net.csproj Outdated Show resolved Hide resolved
@stesee stesee requested a review from NightOwl888 August 14, 2024 14:48
@NightOwl888 NightOwl888 merged commit 1854672 into apache:master Aug 15, 2024
200 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexReader GC Performance Issue
3 participants