Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using self generated certificates #523

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

duncaan
Copy link
Contributor

@duncaan duncaan commented Aug 22, 2024

Fixes #

Motivation

We get a SSL cert from another provider (not managed by cert-manager) and do not have a way to provide this to our proxies.

Modifications

Added a variable that defaults to true and will remove the cert-manager certificate.

Verifying this change

  • Make sure that the change passes the CI checks.

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution

@lhotari lhotari merged commit 0031827 into apache:master Aug 23, 2024
31 checks passed
@duncaan duncaan deleted the support-existing-certs branch August 23, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants