From 044fae462c4ce0eafbd1b733f7e02f353d7cdf3f Mon Sep 17 00:00:00 2001
From: Duncan Schulze <13733349+duncaan@users.noreply.github.com>
Date: Thu, 22 Aug 2024 11:38:54 -0400
Subject: [PATCH 1/2] Support using self generated certificates

---
 charts/pulsar/templates/tls-certs-internal.yaml | 2 ++
 charts/pulsar/values.yaml                       | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/charts/pulsar/templates/tls-certs-internal.yaml b/charts/pulsar/templates/tls-certs-internal.yaml
index 1fc4aed8..b14ce157 100644
--- a/charts/pulsar/templates/tls-certs-internal.yaml
+++ b/charts/pulsar/templates/tls-certs-internal.yaml
@@ -21,6 +21,7 @@
 {{- if .Values.certs.internal_issuer.enabled }}
 
 {{- if .Values.tls.proxy.enabled }}
+{{- if .Values.tls.proxy.createCert }}
 apiVersion: "{{ .Values.certs.internal_issuer.apiVersion }}"
 kind: Certificate
 metadata:
@@ -63,6 +64,7 @@ spec:
     group: cert-manager.io
 ---
 {{- end }}
+{{- end }}
 
 {{- if or .Values.tls.broker.enabled (or .Values.tls.bookie.enabled .Values.tls.zookeeper.enabled) }}
 apiVersion: "{{ .Values.certs.internal_issuer.apiVersion }}"
diff --git a/charts/pulsar/values.yaml b/charts/pulsar/values.yaml
index 45c332c7..5d34e73f 100755
--- a/charts/pulsar/values.yaml
+++ b/charts/pulsar/values.yaml
@@ -226,6 +226,7 @@ tls:
   proxy:
     enabled: false
     cert_name: tls-proxy
+    createCert: true # set to false if you want to use an existing certificate
   # settings for generating certs for broker
   broker:
     enabled: false
@@ -1425,6 +1426,9 @@ pulsar_manager:
     ui_password: ""  # leave empty for random password
     db_username: "pulsar"
     db_password: ""  # leave empty for random password
+    dbExistingSecret: ""
+    dbUsernameKey: "" # leave empty to use default key
+    dbPasswordKey: "" # leave empty to use default key
 
 # These are jobs where job ttl configuration is used
 # pulsar-helm-chart/charts/pulsar/templates/pulsar-cluster-initialize.yaml

From 54d84c87367e1f78bc75ca44f2bf8ca0e7425f85 Mon Sep 17 00:00:00 2001
From: Duncan Schulze <13733349+duncaan@users.noreply.github.com>
Date: Fri, 23 Aug 2024 09:47:41 -0400
Subject: [PATCH 2/2] chore: fix linting

---
 charts/pulsar/values.yaml | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/charts/pulsar/values.yaml b/charts/pulsar/values.yaml
index 5d34e73f..ec9bdbc5 100755
--- a/charts/pulsar/values.yaml
+++ b/charts/pulsar/values.yaml
@@ -226,7 +226,7 @@ tls:
   proxy:
     enabled: false
     cert_name: tls-proxy
-    createCert: true # set to false if you want to use an existing certificate
+    createCert: true  # set to false if you want to use an existing certificate
   # settings for generating certs for broker
   broker:
     enabled: false
@@ -1426,9 +1426,6 @@ pulsar_manager:
     ui_password: ""  # leave empty for random password
     db_username: "pulsar"
     db_password: ""  # leave empty for random password
-    dbExistingSecret: ""
-    dbUsernameKey: "" # leave empty to use default key
-    dbPasswordKey: "" # leave empty to use default key
 
 # These are jobs where job ttl configuration is used
 # pulsar-helm-chart/charts/pulsar/templates/pulsar-cluster-initialize.yaml