Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEZ-4575: Upgrade Apache parent pom version from 23 to 33 #364

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zabetak
Copy link
Contributor

@zabetak zabetak commented Aug 13, 2024

Upgrade the Apache parent pom to the 33 version (latest) to take advantage of recent enhancements and use the more recent version and properties for the various plugins.

The maven-antrun-plugin from version 3.0.0 onwards requires the replacement of the tasks parameter with target.

Upgrade the Apache parent pom to the 33 version (latest) to take advantage of recent enhancements and use the more recent version and properties for the various plugins.
@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 13m 39s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 6m 29s Maven dependency ordering for branch
+1 💚 mvninstall 8m 6s master passed
+1 💚 compile 2m 28s master passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04
+1 💚 compile 2m 28s master passed with JDK Private Build-1.8.0_422-8u422-b05-1~22.04-b05
+1 💚 javadoc 1m 41s master passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04
+1 💚 javadoc 1m 30s master passed with JDK Private Build-1.8.0_422-8u422-b05-1~22.04-b05
_ Patch Compile Tests _
+0 🆗 mvndep 0m 58s Maven dependency ordering for patch
+1 💚 mvninstall 3m 21s the patch passed
-1 ❌ compile 0m 17s tez-dag in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04.
-1 ❌ compile 0m 16s tez-tests in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04.
-1 ❌ compile 0m 17s tez-ext-service-tests in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04.
-1 ❌ compile 0m 15s root in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04.
-1 ❌ javac 0m 17s tez-dag in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04.
-1 ❌ javac 0m 16s tez-tests in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04.
-1 ❌ javac 0m 17s tez-ext-service-tests in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04.
-1 ❌ javac 0m 15s root in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04.
+1 💚 compile 2m 3s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~22.04-b05
-1 ❌ javac 0m 59s root-jdkPrivateBuild-1.8.0_422-8u422-b05-122.04-b05 with JDK Private Build-1.8.0_422-8u422-b05-122.04-b05 generated 2 new + 4 unchanged - 0 fixed = 6 total (was 4)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 3s The patch has no ill-formed XML file.
+1 💚 yamllint 0m 0s There were no new yamllint issues.
-1 ❌ javadoc 0m 16s root in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04.
+1 💚 javadoc 1m 34s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~22.04-b05
_ Other Tests _
+1 💚 unit 4m 28s tez-dag in the patch passed.
+1 💚 unit 37m 14s tez-tests in the patch passed.
+1 💚 unit 4m 5s tez-ext-service-tests in the patch passed.
-1 ❌ unit 65m 48s root in the patch failed.
+1 💚 asflicense 1m 36s The patch does not generate ASF License warnings.
161m 9s
Reason Tests
Failed junit tests tez.analyzer.TestAnalyzer
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-364/2/artifact/out/Dockerfile
GITHUB PR #364
JIRA Issue TEZ-4575
Optional Tests dupname asflicense yamllint javac javadoc unit xml compile
uname Linux 93af42a8b4fa 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5 20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / cd6ceec
Default Java Private Build-1.8.0_422-8u422-b05-1~22.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~22.04-b05
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-364/2/artifact/out/patch-compile-tez-dag-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-364/2/artifact/out/patch-compile-tez-tests-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-364/2/artifact/out/patch-compile-tez-ext-service-tests-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-364/2/artifact/out/patch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-364/2/artifact/out/patch-compile-tez-dag-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-364/2/artifact/out/patch-compile-tez-tests-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-364/2/artifact/out/patch-compile-tez-ext-service-tests-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-364/2/artifact/out/patch-compile-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-364/2/artifact/out/diff-compile-javac-root-jdkPrivateBuild-1.8.0_422-8u422-b05-1~22.04-b05.txt
javadoc https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-364/2/artifact/out/patch-javadoc-root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04.txt
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-364/2/artifact/out/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-364/2/testReport/
Max. process+thread count 1589 (vs. ulimit of 5500)
modules C: tez-dag tez-tests tez-ext-service-tests . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-364/2/console
versions git=2.34.1 maven=3.6.3 yamllint=1.24.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
Copy link
Contributor

thanks @zabetak for taking care of this!
I can see this doesn't compile in the precommit, did it successfully compile locally for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants