Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Provide transaction name for compiler annotations #276

Closed
honzajavorek opened this issue May 6, 2019 · 2 comments
Closed

Provide transaction name for compiler annotations #276

honzajavorek opened this issue May 6, 2019 · 2 comments
Labels

Comments

@honzajavorek
Copy link
Contributor

Unline errors and warnings (annotations) coming from the parser, the ones coming from the compiler currently don't provide line/column numbers. Instead, they provide at least the origin of the relevant transaction.

It would be nice to provide line numbers as well - see https://github.com/apiaryio/dredd-transactions/issues/275. Until that's done, we are showing users the transaction name of the relevant transaction in Dredd's logging. However, since the annotations coming from Dredd Transactions don't contain the transaction name, it needs to be reconstructed in Dredd. This is error-prone and unnecessary duplication. We should add name to the interface of compiler annotations Dredd Transactions provide.

@honzajavorek
Copy link
Contributor Author

Once this is done a file lib/compileTransactionName.js should be removed from Dredd (added in apiaryio/dredd#1351 as a workaround).

@ApiaryBot
Copy link
Collaborator

🎉 This issue has been resolved in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants