Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Fixes syntactically invalid JavaScript #1525

Merged
merged 2 commits into from
Sep 30, 2019
Merged

Fixes syntactically invalid JavaScript #1525

merged 2 commits into from
Sep 30, 2019

Conversation

artem-zakharchenko
Copy link
Contributor

@artem-zakharchenko artem-zakharchenko commented Sep 30, 2019 •
edited
Loading

🚀 Why this change?

  • Certain parts look like survivors after decaffeinate, and represent invalid JavaScript code

📝 Related issues and Pull Requests

✅ What didn't I forget?

  • To write docs
  • To write tests
  • To put Conventional Changelog prefixes in front of all my commits and run npm run lint

@artem-zakharchenko artem-zakharchenko force-pushed the 1524-code-cleanup branch 2 times, most recently from 20b366b to d18ab65 Compare September 30, 2019 09:09
@artem-zakharchenko
Copy link
Contributor Author

These look like all places that were found to be auto-formatted with prepending a semicolon when introduced Prettier. Please review, @honzajavorek.

@artem-zakharchenko artem-zakharchenko mentioned this pull request Sep 30, 2019
Closed
6 tasks
honzajavorek
honzajavorek approved these changes Sep 30, 2019
View reviewed changes
lib/Dredd.js Outdated Show resolved Hide resolved
@honzajavorek
Copy link
Contributor

The commits are fix:. From user's point of view, is it really a fix or is it refactor?

@artem-zakharchenko
Copy link
Contributor Author

@honzajavorek, thanks! Provided the suggestions:

  • Marked commits as refactor:
  • Used usesOptions variable, and reversed the logic to remain the same as before refactoring

@artem-zakharchenko artem-zakharchenko merged commit 556be27 into master Sep 30, 2019
@artem-zakharchenko artem-zakharchenko deleted the 1524-code-cleanup branch September 30, 2019 12:40
@ApiaryBot
Copy link
Collaborator

🎉 This PR is included in version 12.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@honzajavorek honzajavorek honzajavorek approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artem-zakharchenko @honzajavorek @ApiaryBot