Fix issue #22 (rule lookup does not count inheritance) #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #22
The issue is with cache strictly bound to the class object.
Rule lookup doesn't count inheritance correctly.
Then, if you have
It generates
While it should generate
Diff looks a bit scary but basically i added just 3 lines to deal with inheritance.
This fix passes all tests.
I fixed this fragment
by wrapping in
.mro()
lookup loop:I'm not 100% sure about solution. Flask-Classy is kinda tricky ;)
I'm sure even less about git though...