Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when i use some complex decorator.
the get_true_argspec do something wrong with closure
for example
def func_permission(check_func, **deco_kwargs):
def wrapper(fn):
@wraps(fn)
def decorated_view(_args, *_kwargs):
result = check_func(**deco_kwargs)
if result:
return fn(_args, *_kwargs)
return while_no_permission()
return decorated_view
return wrapper
@func_permission(some_check_func)
def get(self, restaurant_id):
restaurant_id = int(restaurant_id)
will raise DecoratorCompatibilityError
this commit will fix this error.
the new get_true_argspec
before raise this exception,will check weather this is the real undecorate function by check the function name.
by the way,which is the best way to post code,bug and the way to re produce this bug?