Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix when use some complex decorator #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix when use some complex decorator #62

wants to merge 1 commit into from

Conversation

noodle4u
Copy link

@noodle4u noodle4u commented Aug 6, 2014

when i use some complex decorator.
the get_true_argspec do something wrong with closure
for example

def func_permission(check_func, **deco_kwargs):
def wrapper(fn):
@wraps(fn)
def decorated_view(_args, *_kwargs):
result = check_func(**deco_kwargs)
if result:
return fn(_args, *_kwargs)
return while_no_permission()
return decorated_view
return wrapper

@func_permission(some_check_func)
def get(self, restaurant_id):
restaurant_id = int(restaurant_id)

will raise DecoratorCompatibilityError

this commit will fix this error.
the new get_true_argspec
before raise this exception,will check weather this is the real undecorate function by check the function name.

by the way,which is the best way to post code,bug and the way to re produce this bug?

@noodle4u
Copy link
Author

noodle4u commented Aug 6, 2014

sorry 4 that i didn't use markdown to format-.-...

@chrishaines
Copy link

+1 I've run into this issue as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants