Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Websocket compression #1406

Closed
bridger opened this issue Feb 18, 2020 · 1 comment
Closed

Support for Websocket compression #1406

bridger opened this issue Feb 18, 2020 · 1 comment

Comments

@bridger
Copy link

bridger commented Feb 18, 2020

I'm curious if compression support has been considered for Websockets in NIO. I'd be interested in using it in my server-side app.

Kitura developed this package for websocket compression built on NIO's websockets. I asked about it being supported in Vapor and @tanner0101 suggested it would be very convenient to have it live directly in NIO.

How do you decide which parts of the Websocket spec are included in NIO and which are up to clients? I know Compression is an extension to Websockets, but it is pretty standard in most packages.

@Lukasa
Copy link
Contributor

Lukasa commented Feb 18, 2020

NIO is very reluctant to take on a dependency on zlib: in fact, we removed a previous HTTP compression library to swift-nio-extras for this very reason. I think we'd be happy to accept a patch in swift-nio-extras that implements this extension, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants