From bf5cabea081afce77c19ec0e107d3aedd12e4b99 Mon Sep 17 00:00:00 2001 From: Franz Busch Date: Mon, 22 Jul 2024 16:40:23 +0200 Subject: [PATCH 1/6] [GHA] Make unit tests, benchmarks and cxx interop easier to reuse # Motivation Currently the `pull_request_swift_matrix` workflow provided an easy way to run a command across many Swift versions. We do have a few common commands that we want to run across the repos. Namely, unit tests, benchmarks and cxx interop. # Modification This PR creates new workflows for the above common matrix commands so it's easier to reuse them from other repos. # Result Even easier to share these workflows. --- .github/workflows/benchmarks.yml | 38 ++++++++++++++++++ .github/workflows/cxx_interop.yml | 38 ++++++++++++++++++ .github/workflows/pull_request.yml | 59 ++++++++++++---------------- .github/workflows/unit_tests.yml | 63 ++++++++++++++++++++++++++++++ 4 files changed, 164 insertions(+), 34 deletions(-) create mode 100644 .github/workflows/benchmarks.yml create mode 100644 .github/workflows/cxx_interop.yml create mode 100644 .github/workflows/unit_tests.yml diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml new file mode 100644 index 0000000000..15d2487db0 --- /dev/null +++ b/.github/workflows/benchmarks.yml @@ -0,0 +1,38 @@ +name: Benchmarks + +on: + workflow_call: + inputs: + linux_5_8_enabled: + type: boolean + description: "Boolean to enable the Linux 5.8 Swift version matrix job. Defaults to true." + default: true + linux_5_9_enabled: + type: boolean + description: "Boolean to enable the Linux 5.9 Swift version matrix job. Defaults to true." + default: true + linux_5_10_enabled: + type: boolean + description: "Boolean to enable the Linux 5.10 Swift version matrix job. Defaults to true." + default: true + linux_nightly_6_0_enabled: + type: boolean + description: "Boolean to enable the Linux nightly 6.0 Swift version matrix job. Defaults to true." + default: true + linux_nightly_main_enabled: + type: boolean + description: "Boolean to enable the Linux nightly main Swift version matrix job. Defaults to true." + default: true + +jobs: + benchmarks: + name: Benchmarks + uses: ./.github/workflows/pull_request_swift_matrix.yml + with: + name: "Benchmarks" + matrix_linux_command: "apt-get update -y -q && apt-get install -y -q libjemalloc-dev && swift package --package-path Benchmarks/ --disable-sandbox benchmark baseline check --check-absolute-path Benchmarks/Thresholds/${SWIFT_VERSION}/" + matrix_linux_5_8_enabled: ${{ inputs.linux_5_8_enabled }} + matrix_linux_5_9_enabled: ${{ inputs.linux_5_9_enabled }} + matrix_linux_5_10_enabled: ${{ inputs.linux_5_10_enabled }} + matrix_linux_nightly_6_0_enabled: ${{ inputs.linux_nightly_6_0_enabled }} + matrix_linux_nightly_main_enabled: ${{ inputs.linux_nightly_main_enabled }} \ No newline at end of file diff --git a/.github/workflows/cxx_interop.yml b/.github/workflows/cxx_interop.yml new file mode 100644 index 0000000000..a293bd36e0 --- /dev/null +++ b/.github/workflows/cxx_interop.yml @@ -0,0 +1,38 @@ +name: Cxx interop + +on: + workflow_call: + inputs: + linux_5_8_enabled: + type: boolean + description: "Boolean to enable the Linux 5.8 Swift version matrix job. Defaults to true." + default: true + linux_5_9_enabled: + type: boolean + description: "Boolean to enable the Linux 5.9 Swift version matrix job. Defaults to true." + default: true + linux_5_10_enabled: + type: boolean + description: "Boolean to enable the Linux 5.10 Swift version matrix job. Defaults to true." + default: true + linux_nightly_6_0_enabled: + type: boolean + description: "Boolean to enable the Linux nightly 6.0 Swift version matrix job. Defaults to true." + default: true + linux_nightly_main_enabled: + type: boolean + description: "Boolean to enable the Linux nightly main Swift version matrix job. Defaults to true." + default: true + +jobs: + cxx-interop: + name: Cxx interop + uses: ./.github/workflows/pull_request_swift_matrix.yml + with: + name: "Cxx interop" + matrix_linux_command: "apt-get update -y -q && apt-get install -y -q jq && ./scripts/check-cxx-interop-compatibility.sh" + matrix_linux_5_8_enabled: ${{ inputs.linux_5_8_enabled }} + matrix_linux_5_9_enabled: ${{ inputs.linux_5_9_enabled }} + matrix_linux_5_10_enabled: ${{ inputs.linux_5_10_enabled }} + matrix_linux_nightly_6_0_enabled: ${{ inputs.linux_nightly_6_0_enabled }} + matrix_linux_nightly_main_enabled: ${{ inputs.linux_nightly_main_enabled }} \ No newline at end of file diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 1e95efced1..145ca7d516 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -1,43 +1,34 @@ name: Pull Request on: - pull_request: - types: [opened, reopened, synchronize] + pull_request: + types: [opened, reopened, synchronize] jobs: - call-pull-request-soundness-workflow: - name: Soundness - uses: ./.github/workflows/pull_request_soundness.yml - with: - license_header_check_project_name: "SwiftNIO" + soundness: + name: Soundness + uses: ./.github/workflows/pull_request_soundness.yml + with: + license_header_check_project_name: "SwiftNIO" - call-pull-request-unit-tests-workflow: - name: Unit tests - uses: ./.github/workflows/pull_request_swift_matrix.yml - with: - name: "Unit tests" - matrix_linux_command: "swift test -Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" - # Disable warnings as errors: Swift 6 emits sendability warnings that haven't been dealt with yet. - matrix_linux_nightly_main_command_override: "swift test --explicit-target-dependency-import-check error" - matrix_linux_nightly_6_0_command_override: "swift test --explicit-target-dependency-import-check error" + unit-tests: + name: Checks + uses: ./.github/workflows/unit_tests.yml + with: + linux_nightly_6_0_arguments_override: "--explicit-target-dependency-import-check error" + linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error" - call-pull-request-benchmark-workflow: - name: Benchmarks - uses: ./.github/workflows/pull_request_swift_matrix.yml - with: - name: "Benchmarks" - matrix_linux_command: "apt-get update -y -q && apt-get install -y -q libjemalloc-dev && swift package --package-path Benchmarks/ --disable-sandbox benchmark baseline check --check-absolute-path Benchmarks/Thresholds/${SWIFT_VERSION}/" + benchmarks: + name: Checks + uses: ./.github/workflows/benchmarks.yml - call-pull-request-cxx-interop-workflow: - name: Cxx interop - uses: ./.github/workflows/pull_request_swift_matrix.yml - with: - name: "Cxx interop" - matrix_linux_command: "apt-get update -y -q && apt-get install -y -q jq && ./scripts/check-cxx-interop-compatibility.sh" + cxx-interop: + name: Checks + uses: ./.github/workflows/cxx_interop.yml - call-pull-request-integration-tests-workflow: - name: Integration tests - uses: ./.github/workflows/pull_request_swift_matrix.yml - with: - name: "Integration tests" - matrix_linux_command: "apt-get update -y -q && apt-get install -y -q lsof dnsutils netcat-openbsd net-tools curl jq && ./scripts/integration_tests.sh" + integration-tests: + name: Checks + uses: ./.github/workflows/pull_request_swift_matrix.yml + with: + name: "Integration tests" + matrix_linux_command: "apt-get update -y -q && apt-get install -y -q lsof dnsutils netcat-openbsd net-tools curl jq && ./scripts/integration_tests.sh" diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml new file mode 100644 index 0000000000..4fcd016c1f --- /dev/null +++ b/.github/workflows/unit_tests.yml @@ -0,0 +1,63 @@ +name: Unit tests + +on: + workflow_call: + inputs: + linux_5_8_enabled: + type: boolean + description: "Boolean to enable the Linux 5.8 Swift version matrix job. Defaults to true." + default: true + linux_5_8_arguments_override: + type: string + description: "The arguments passed to swift test in the Linux 5.8 Swift version matrix job." + default: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" + linux_5_9_enabled: + type: boolean + description: "Boolean to enable the Linux 5.9 Swift version matrix job. Defaults to true." + default: true + linux_5_9_arguments_override: + type: string + description: "The arguments passed to swift test in the Linux 5.9 Swift version matrix job." + default: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" + linux_5_10_enabled: + type: boolean + description: "Boolean to enable the Linux 5.10 Swift version matrix job. Defaults to true." + default: true + linux_5_10_arguments_override: + type: string + description: "The arguments passed to swift test in the Linux 5.10 Swift version matrix job." + default: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" + linux_nightly_6_0_enabled: + type: boolean + description: "Boolean to enable the Linux nightly 6.0 Swift version matrix job. Defaults to true." + default: true + linux_nightly_6_0_arguments_override: + type: string + description: "The arguments passed to swift test in the Linux nightly 6.0 Swift version matrix job." + default: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" + linux_nightly_main_enabled: + type: boolean + description: "Boolean to enable the Linux nightly main Swift version matrix job. Defaults to true." + default: true + linux_nightly_main_arguments_override: + type: string + description: "The arguments passed to swift test in the Linux nightly main Swift version matrix job." + default: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" + +jobs: + unit-tests: + name: Unit tests + uses: ./.github/workflows/pull_request_swift_matrix.yml + with: + name: "Unit tests" + matrix_linux_command: "swift test -Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" + matrix_linux_5_8_enabled: ${{ inputs.linux_5_8_enabled }} + matrix_linux_5_8_command_override: "swift test ${{ inputs.linux_5_8_arguments_override }}" + matrix_linux_5_9_enabled: ${{ inputs.linux_5_9_enabled }} + matrix_linux_5_9_command_override: "swift test ${{ inputs.linux_5_9_arguments_override }}" + matrix_linux_5_10_enabled: ${{ inputs.linux_5_10_enabled }} + matrix_linux_5_10_command_override: "swift test ${{ inputs.linux_5_10_arguments_override }}" + matrix_linux_nightly_6_0_enabled: ${{ inputs.linux_nightly_6_0_enabled }} + matrix_linux_nightly_6_0_command_override: "swift test ${{ inputs.linux_nightly_6_0_arguments_override }}" + matrix_linux_nightly_main_enabled: ${{ inputs.linux_nightly_main_enabled }} + matrix_linux_nightly_main_command_override: "swift test ${{ inputs.linux_nightly_main_arguments_override }}" \ No newline at end of file From 9ad513d0f1ba7a0397390a4e652f878b0dbc4606 Mon Sep 17 00:00:00 2001 From: Franz Busch Date: Tue, 23 Jul 2024 11:43:53 +0200 Subject: [PATCH 2/6] Review comments --- .github/workflows/benchmarks.yml | 9 ++++++++- .github/workflows/cxx_interop.yml | 4 ++-- .github/workflows/pull_request_swift_matrix.yml | 2 +- .github/workflows/unit_tests.yml | 2 +- 4 files changed, 12 insertions(+), 5 deletions(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 15d2487db0..3aa6eff0f5 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -3,6 +3,13 @@ name: Benchmarks on: workflow_call: inputs: + benchmark_package_path: + type: string + description: "Path to the directory containing the benchmarking package. Defaults to ." + default: "." + swift_package_arguments: + type: string + description: "Arguments to the switch package command invocation e.g. `--disable-sandbox`" linux_5_8_enabled: type: boolean description: "Boolean to enable the Linux 5.8 Swift version matrix job. Defaults to true." @@ -30,7 +37,7 @@ jobs: uses: ./.github/workflows/pull_request_swift_matrix.yml with: name: "Benchmarks" - matrix_linux_command: "apt-get update -y -q && apt-get install -y -q libjemalloc-dev && swift package --package-path Benchmarks/ --disable-sandbox benchmark baseline check --check-absolute-path Benchmarks/Thresholds/${SWIFT_VERSION}/" + matrix_linux_command: "apt-get update -y -q && apt-get install -y -q libjemalloc-dev && swift package --package-path ${{ inputs.benchmark_package_path }} ${{ inputs.swift_package_arguments }} benchmark baseline check --check-absolute-path ${{ inputs.benchmark_package_path }}/Thresholds/${SWIFT_VERSION}/" matrix_linux_5_8_enabled: ${{ inputs.linux_5_8_enabled }} matrix_linux_5_9_enabled: ${{ inputs.linux_5_9_enabled }} matrix_linux_5_10_enabled: ${{ inputs.linux_5_10_enabled }} diff --git a/.github/workflows/cxx_interop.yml b/.github/workflows/cxx_interop.yml index a293bd36e0..bf2fb6a937 100644 --- a/.github/workflows/cxx_interop.yml +++ b/.github/workflows/cxx_interop.yml @@ -30,9 +30,9 @@ jobs: uses: ./.github/workflows/pull_request_swift_matrix.yml with: name: "Cxx interop" - matrix_linux_command: "apt-get update -y -q && apt-get install -y -q jq && ./scripts/check-cxx-interop-compatibility.sh" + matrix_linux_command: "apt-get update -y -q && apt-get install -y -q jq && curl -s https://raw.githubusercontent.com/apple/swift-nio/main/scripts/check-cxx-interop-compatibility.sh | bash" matrix_linux_5_8_enabled: ${{ inputs.linux_5_8_enabled }} matrix_linux_5_9_enabled: ${{ inputs.linux_5_9_enabled }} matrix_linux_5_10_enabled: ${{ inputs.linux_5_10_enabled }} matrix_linux_nightly_6_0_enabled: ${{ inputs.linux_nightly_6_0_enabled }} - matrix_linux_nightly_main_enabled: ${{ inputs.linux_nightly_main_enabled }} \ No newline at end of file + matrix_linux_nightly_main_enabled: ${{ inputs.linux_nightly_main_enabled }} diff --git a/.github/workflows/pull_request_swift_matrix.yml b/.github/workflows/pull_request_swift_matrix.yml index 012e535fde..85b666041f 100644 --- a/.github/workflows/pull_request_swift_matrix.yml +++ b/.github/workflows/pull_request_swift_matrix.yml @@ -93,4 +93,4 @@ jobs: COMMAND_OVERRIDE_NIGHTLY_MAIN: ${{ inputs.matrix_linux_nightly_main_command_override }} run: | apt-get -qq update && apt-get -qq -y install curl - curl -s https://raw.githubusercontent.com/apple/swift-nio/main/scripts/check-matrix-job.sh | bash \ No newline at end of file + curl -s https://raw.githubusercontent.com/apple/swift-nio/main/scripts/check-matrix-job.sh | bash diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml index 4fcd016c1f..4e49f4cf23 100644 --- a/.github/workflows/unit_tests.yml +++ b/.github/workflows/unit_tests.yml @@ -60,4 +60,4 @@ jobs: matrix_linux_nightly_6_0_enabled: ${{ inputs.linux_nightly_6_0_enabled }} matrix_linux_nightly_6_0_command_override: "swift test ${{ inputs.linux_nightly_6_0_arguments_override }}" matrix_linux_nightly_main_enabled: ${{ inputs.linux_nightly_main_enabled }} - matrix_linux_nightly_main_command_override: "swift test ${{ inputs.linux_nightly_main_arguments_override }}" \ No newline at end of file + matrix_linux_nightly_main_command_override: "swift test ${{ inputs.linux_nightly_main_arguments_override }}" From 12bd6c5d1d2b31053941eb5bb01eadea6c53cb55 Mon Sep 17 00:00:00 2001 From: Franz Busch Date: Tue, 23 Jul 2024 11:57:18 +0200 Subject: [PATCH 3/6] Pass benchmark path --- .github/workflows/pull_request.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 145ca7d516..eaea709bfd 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -21,6 +21,8 @@ jobs: benchmarks: name: Checks uses: ./.github/workflows/benchmarks.yml + with: + benchmark_package_path: "Benchmarks" cxx-interop: name: Checks From e0372b2d02a357dd10a698606ca6d8d50fffbfa4 Mon Sep 17 00:00:00 2001 From: Franz Busch Date: Wed, 24 Jul 2024 11:04:44 +0200 Subject: [PATCH 4/6] Rename and cleanup --- .github/workflows/benchmarks.yml | 2 +- .github/workflows/cxx_interop.yml | 2 +- .github/workflows/pull_request.yml | 4 ++-- .../workflows/{pull_request_soundness.yml => soundness.yml} | 2 +- .../{pull_request_swift_matrix.yml => swift_matrix.yml} | 0 .github/workflows/unit_tests.yml | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) rename .github/workflows/{pull_request_soundness.yml => soundness.yml} (99%) rename .github/workflows/{pull_request_swift_matrix.yml => swift_matrix.yml} (100%) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 3aa6eff0f5..3c1b501ad2 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -34,7 +34,7 @@ on: jobs: benchmarks: name: Benchmarks - uses: ./.github/workflows/pull_request_swift_matrix.yml + uses: ./.github/workflows/swift_matrix.yml with: name: "Benchmarks" matrix_linux_command: "apt-get update -y -q && apt-get install -y -q libjemalloc-dev && swift package --package-path ${{ inputs.benchmark_package_path }} ${{ inputs.swift_package_arguments }} benchmark baseline check --check-absolute-path ${{ inputs.benchmark_package_path }}/Thresholds/${SWIFT_VERSION}/" diff --git a/.github/workflows/cxx_interop.yml b/.github/workflows/cxx_interop.yml index bf2fb6a937..af4d7b004e 100644 --- a/.github/workflows/cxx_interop.yml +++ b/.github/workflows/cxx_interop.yml @@ -27,7 +27,7 @@ on: jobs: cxx-interop: name: Cxx interop - uses: ./.github/workflows/pull_request_swift_matrix.yml + uses: ./.github/workflows/swift_matrix.yml with: name: "Cxx interop" matrix_linux_command: "apt-get update -y -q && apt-get install -y -q jq && curl -s https://raw.githubusercontent.com/apple/swift-nio/main/scripts/check-cxx-interop-compatibility.sh | bash" diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index eaea709bfd..1f51880a18 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -7,7 +7,7 @@ on: jobs: soundness: name: Soundness - uses: ./.github/workflows/pull_request_soundness.yml + uses: ./.github/workflows/soundness.yml with: license_header_check_project_name: "SwiftNIO" @@ -30,7 +30,7 @@ jobs: integration-tests: name: Checks - uses: ./.github/workflows/pull_request_swift_matrix.yml + uses: ./.github/workflows/swift_matrix.yml with: name: "Integration tests" matrix_linux_command: "apt-get update -y -q && apt-get install -y -q lsof dnsutils netcat-openbsd net-tools curl jq && ./scripts/integration_tests.sh" diff --git a/.github/workflows/pull_request_soundness.yml b/.github/workflows/soundness.yml similarity index 99% rename from .github/workflows/pull_request_soundness.yml rename to .github/workflows/soundness.yml index f0cccd88c2..62d750a4fe 100644 --- a/.github/workflows/pull_request_soundness.yml +++ b/.github/workflows/soundness.yml @@ -1,4 +1,4 @@ -name: Pull Request +name: Soundness on: workflow_call: diff --git a/.github/workflows/pull_request_swift_matrix.yml b/.github/workflows/swift_matrix.yml similarity index 100% rename from .github/workflows/pull_request_swift_matrix.yml rename to .github/workflows/swift_matrix.yml diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml index 4e49f4cf23..44c712a83d 100644 --- a/.github/workflows/unit_tests.yml +++ b/.github/workflows/unit_tests.yml @@ -47,7 +47,7 @@ on: jobs: unit-tests: name: Unit tests - uses: ./.github/workflows/pull_request_swift_matrix.yml + uses: ./.github/workflows/swift_matrix.yml with: name: "Unit tests" matrix_linux_command: "swift test -Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" From 5cb864f94ddbdac89024ee6f51799ceb3e069684 Mon Sep 17 00:00:00 2001 From: Franz Busch Date: Wed, 24 Jul 2024 11:22:11 +0200 Subject: [PATCH 5/6] Remove default arguments for testing --- .github/workflows/pull_request.yml | 3 +++ .github/workflows/unit_tests.yml | 12 ++++++------ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 1f51880a18..50bc059859 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -15,6 +15,9 @@ jobs: name: Checks uses: ./.github/workflows/unit_tests.yml with: + linux_5_8_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" + linux_5_9_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" + linux_5_10_arguments_override: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" linux_nightly_6_0_arguments_override: "--explicit-target-dependency-import-check error" linux_nightly_main_arguments_override: "--explicit-target-dependency-import-check error" diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml index 44c712a83d..c39038cdb8 100644 --- a/.github/workflows/unit_tests.yml +++ b/.github/workflows/unit_tests.yml @@ -10,7 +10,7 @@ on: linux_5_8_arguments_override: type: string description: "The arguments passed to swift test in the Linux 5.8 Swift version matrix job." - default: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" + default: "" linux_5_9_enabled: type: boolean description: "Boolean to enable the Linux 5.9 Swift version matrix job. Defaults to true." @@ -18,7 +18,7 @@ on: linux_5_9_arguments_override: type: string description: "The arguments passed to swift test in the Linux 5.9 Swift version matrix job." - default: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" + default: "" linux_5_10_enabled: type: boolean description: "Boolean to enable the Linux 5.10 Swift version matrix job. Defaults to true." @@ -26,7 +26,7 @@ on: linux_5_10_arguments_override: type: string description: "The arguments passed to swift test in the Linux 5.10 Swift version matrix job." - default: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" + default: "" linux_nightly_6_0_enabled: type: boolean description: "Boolean to enable the Linux nightly 6.0 Swift version matrix job. Defaults to true." @@ -34,7 +34,7 @@ on: linux_nightly_6_0_arguments_override: type: string description: "The arguments passed to swift test in the Linux nightly 6.0 Swift version matrix job." - default: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" + default: "" linux_nightly_main_enabled: type: boolean description: "Boolean to enable the Linux nightly main Swift version matrix job. Defaults to true." @@ -42,7 +42,7 @@ on: linux_nightly_main_arguments_override: type: string description: "The arguments passed to swift test in the Linux nightly main Swift version matrix job." - default: "-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" + default: "" jobs: unit-tests: @@ -50,7 +50,7 @@ jobs: uses: ./.github/workflows/swift_matrix.yml with: name: "Unit tests" - matrix_linux_command: "swift test -Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error" + matrix_linux_command: "swift test" matrix_linux_5_8_enabled: ${{ inputs.linux_5_8_enabled }} matrix_linux_5_8_command_override: "swift test ${{ inputs.linux_5_8_arguments_override }}" matrix_linux_5_9_enabled: ${{ inputs.linux_5_9_enabled }} From 9bc8b3c5847eba6562e88b491aebb704c17a5d1a Mon Sep 17 00:00:00 2001 From: Franz Busch Date: Wed, 24 Jul 2024 11:31:44 +0200 Subject: [PATCH 6/6] Rename integration test checks --- .github/workflows/pull_request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 50bc059859..dc1b5f884d 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -32,7 +32,7 @@ jobs: uses: ./.github/workflows/cxx_interop.yml integration-tests: - name: Checks + name: Checks / Integration Tests uses: ./.github/workflows/swift_matrix.yml with: name: "Integration tests"