Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test suite #299

Open
10 of 12 tasks
tombruijn opened this issue May 26, 2017 · 0 comments
Open
10 of 12 tasks

Refactor test suite #299

tombruijn opened this issue May 26, 2017 · 0 comments

Comments

@tombruijn
Copy link
Member

tombruijn commented May 26, 2017

  • Use a random order for the test suite. Spot problems with connected tests.
  • Don't unit test integration(s middleware), but test against an actual app. See Padrino tests for an example.
  • Refactor out testing private methods
  • Less stubbing and mocking
  • Test transaction contents from extension.
  • Less before :all|context usage
  • Less instance variables usage
  • Fix env var tests: Fix configuring instrument redis and sequel from env #257 (review)
  • spec/lib/appsignal_spec.rb, many spec with expect do .. end.to_not raise_error useless checks. Spec fails if an error occurs
  • Clean up test output -> Explicit header whitelist in configuration #406 (comment)
    • If logs are printed in the test output that are important to see, we should test their presence
  • Remove "duplicate" builds from Travis
    • We now test against a lot of combinations of Ruby versions and gems, but I think we can decrease the amount a bit. Decrease/Drop the 2.1.x-2.3.x builds for all combinations of gems/only against Rails and no-deps. Speeds the build up quite a bit.
  • Add macOS to the build on Semaphore.
@tombruijn tombruijn changed the title Refactor test suite ⌨️ Refactor test suite Oct 27, 2017
@tombruijn tombruijn changed the title ⌨️ Refactor test suite Refactor test suite May 30, 2018
tombruijn added a commit that referenced this issue Jul 1, 2024
Make the assertions easier to read by describing what we want to see
happen, rather than assert some Hash of internal representation of the
transaction.

Part of #252
Part of #299

[skip changeset]
tombruijn added a commit that referenced this issue Jul 1, 2024
Make the assertions easier to read by describing what we want to see
happen, rather than assert some Hash of internal representation of the
transaction.

Part of #252
Part of #299

[skip changeset]
tombruijn added a commit that referenced this issue Jul 1, 2024
Make the assertions easier to read by describing what we want to see
happen, rather than assert some Hash of internal representation of the
transaction.

Part of #252
Part of #299

[skip changeset]
tombruijn added a commit that referenced this issue Jul 1, 2024
Refactor the test suite to not test if transactions are created by
asserting method calls. Use the tooling to see if a transaction has been
created or not and assert what's set on the transaction using the
transaction matchers.

Part of #299
Closes #252
tombruijn added a commit that referenced this issue Jul 24, 2024
Make sure AppSignal works on macOS too. Only test the primary Ruby
builds. No need to test every gemset on macOS too. We just want to know
if the Ruby gem installs and works.

Part of #299
tombruijn added a commit that referenced this issue Jul 24, 2024
Make sure AppSignal works on macOS too. Only test the primary Ruby
builds. No need to test every gemset on macOS too. We just want to know
if the Ruby gem installs and works.

Part of #299
tombruijn added a commit that referenced this issue Jul 24, 2024
Make sure AppSignal works on macOS too. Only test the primary Ruby
builds. No need to test every gemset on macOS too. We just want to know
if the Ruby gem installs and works.

Part of #299
tombruijn added a commit that referenced this issue Jul 24, 2024
Make sure AppSignal works on macOS too. Only test the primary Ruby
builds. No need to test every gemset on macOS too. We just want to know
if the Ruby gem installs and works.

Part of #299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant