Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BillingEntity RBAC reconcile #199

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Jan 26, 2024

Summary

Used a cron job since we never implemented watch for BEs.

Some basteling to allow for SSAing the roles.

Checklist

  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@bastjan bastjan added the enhancement New feature or request label Jan 26, 2024
@bastjan bastjan requested a review from a team as a code owner January 26, 2024 10:11
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

Patch can't do a grpc roundtrip (yet) so objects need the full type information.
@bastjan
Copy link
Contributor Author

bastjan commented Jan 26, 2024

Tested in the integration env

@bastjan bastjan merged commit 0810551 into master Jan 26, 2024
3 checks passed
@bastjan bastjan deleted the reconcile-billing-rbac branch January 26, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants