-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Database Deletion Flow #1293
base: main
Are you sure you want to change the base?
Conversation
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-10-03 09:55:08 CET |
@ItzNotABug is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-10-03 09:55:20 CET |
src/routes/console/project-[project]/databases/database-[database]/settings/+page.svelte
Outdated
Show resolved
Hide resolved
Co-authored-by: Carla <[email protected]>
…tABug/appwrite-console into database-deletion-new-flow
Todo: Add message that the database deletion will also delete its associated backups. |
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-10-03 09:55:07 CET |
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-10-03 09:55:14 CET |
src/routes/(console)/project-[project]/databases/database-[database]/delete.svelte
Outdated
Show resolved
Hide resolved
src/routes/(console)/project-[project]/databases/database-[database]/delete.svelte
Outdated
Show resolved
Hide resolved
src/routes/(console)/project-[project]/databases/database-[database]/+page.ts
Show resolved
Hide resolved
:global(.no-inner-borders .table) { | ||
box-shadow: unset; | ||
border-radius: unset; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have an option for this, can you check the Table props?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this even makes a difference, I see no changes with or without it, wonder why I added it back then. As per props, I see noMargins
and noStyles
. Wouldn't use noStyles
on this.
:global(.max-height-dialog dialog) { | ||
max-height: 650px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the collections list can increase and that would increase the modal height too iirc.
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)