Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping up the max transaction execution gas limit for gov proposals #15352

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

vineethk
Copy link
Contributor

@vineethk vineethk commented Nov 21, 2024

Description

Bumps the max transaction execution gas limit for governance proposals to support upgrading the latest framework with compiler v2.

How Has This Been Tested?

Manually tested governance proposal creation and simulation with complier v1 and compiler v2 using these commands.

Type of Change

Configuration change

Copy link

trunk-io bot commented Nov 21, 2024

⏱️ 3h 24m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 51m 🟩🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 12m 🟩
rust-move-tests 12m 🟩
rust-move-tests 12m 🟩
rust-move-tests 12m 🟩
rust-move-tests 12m 🟩
rust-cargo-deny 12m 🟩🟩🟩🟩🟩 (+2 more)
execution-performance / test-target-determinator 10m 🟩🟩
test-target-determinator 9m 🟩🟩
check 7m 🟩🟩
check-dynamic-deps 6m 🟩🟩🟩🟩🟩 (+2 more)
rust-doc-tests 5m 🟩
rust-doc-tests 4m 🟥

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 26m 16m +58%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vineethk vineethk marked this pull request as ready for review November 21, 2024 18:03
@sherry-x sherry-x added the v1.23 label Nov 21, 2024
@vineethk vineethk force-pushed the vk/bump-gov-proposal-gas-limit branch from 3d10161 to ad7cf32 Compare November 21, 2024 23:40
@sherry-x sherry-x enabled auto-merge (rebase) November 25, 2024 15:30

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 2c51612c14151d5eefdf30a0784d6b7e87373d05

two traffics test: inner traffic : committed: 14223.72 txn/s, latency: 2794.76 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3600 ms), latency samples: 5408160
two traffics test : committed: 100.08 txn/s, latency: 2091.10 ms, (p50: 1400 ms, p70: 1900, p90: 2200 ms, p99: 17900 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.353, avg: 1.405", "ConsensusProposalToOrdered: max: 0.322, avg: 0.293", "ConsensusOrderedToCommit: max: 0.372, avg: 0.358", "ConsensusProposalToCommit: max: 0.663, avg: 0.651"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.13s no progress at version 2632522 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.57s no progress at version 2632520 (avg 15.57s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2c51612c14151d5eefdf30a0784d6b7e87373d05

Compatibility test results for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2c51612c14151d5eefdf30a0784d6b7e87373d05 (PR)
Upgrade the nodes to version: 2c51612c14151d5eefdf30a0784d6b7e87373d05
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1470.37 txn/s, submitted: 1471.81 txn/s, failed submission: 1.44 txn/s, expired: 1.44 txn/s, latency: 2324.03 ms, (p50: 2100 ms, p70: 2400, p90: 4000 ms, p99: 5700 ms), latency samples: 122320
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1484.79 txn/s, submitted: 1487.76 txn/s, failed submission: 2.97 txn/s, expired: 2.97 txn/s, latency: 2062.31 ms, (p50: 2000 ms, p70: 2100, p90: 3300 ms, p99: 4200 ms), latency samples: 130120
5. check swarm health
Compatibility test for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2c51612c14151d5eefdf30a0784d6b7e87373d05 passed
Upgrade the remaining nodes to version: 2c51612c14151d5eefdf30a0784d6b7e87373d05
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1425.67 txn/s, submitted: 1428.43 txn/s, failed submission: 2.76 txn/s, expired: 2.76 txn/s, latency: 2324.47 ms, (p50: 2100 ms, p70: 2400, p90: 3400 ms, p99: 4700 ms), latency samples: 124160
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2c51612c14151d5eefdf30a0784d6b7e87373d05

Compatibility test results for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2c51612c14151d5eefdf30a0784d6b7e87373d05 (PR)
1. Check liveness of validators at old version: 94976266c0e4edd1a31a3783be4c4184f8892ff5
compatibility::simple-validator-upgrade::liveness-check : committed: 14615.37 txn/s, latency: 2347.98 ms, (p50: 2100 ms, p70: 2100, p90: 2400 ms, p99: 7800 ms), latency samples: 529920
2. Upgrading first Validator to new version: 2c51612c14151d5eefdf30a0784d6b7e87373d05
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7059.01 txn/s, latency: 3959.03 ms, (p50: 4300 ms, p70: 4800, p90: 5000 ms, p99: 5200 ms), latency samples: 128660
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7332.16 txn/s, latency: 4409.54 ms, (p50: 4700 ms, p70: 4800, p90: 6200 ms, p99: 6700 ms), latency samples: 241600
3. Upgrading rest of first batch to new version: 2c51612c14151d5eefdf30a0784d6b7e87373d05
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7480.69 txn/s, latency: 3646.73 ms, (p50: 3900 ms, p70: 4000, p90: 5100 ms, p99: 5200 ms), latency samples: 154360
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7952.90 txn/s, latency: 3985.89 ms, (p50: 4000 ms, p70: 4000, p90: 6500 ms, p99: 7000 ms), latency samples: 262900
4. upgrading second batch to new version: 2c51612c14151d5eefdf30a0784d6b7e87373d05
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12107.92 txn/s, latency: 2318.42 ms, (p50: 2600 ms, p70: 2700, p90: 2700 ms, p99: 2800 ms), latency samples: 210660
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10324.30 txn/s, latency: 2869.49 ms, (p50: 2700 ms, p70: 2700, p90: 2800 ms, p99: 7400 ms), latency samples: 397000
5. check swarm health
Compatibility test for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> 2c51612c14151d5eefdf30a0784d6b7e87373d05 passed
Test Ok

@sherry-x sherry-x merged commit e2359fd into main Nov 25, 2024
48 checks passed
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
aptos-release-v1.23

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants