Fix Emitted Data for `aptos-token-objects::collection::Mutation` V2 Event #15375

junkil-park · 2024-11-22T22:01:15Z

Description

In aptos-token-objects::collection, the set_description and set_uri functions replace the data with the new value before emitting the event. This causes the Mutation V2 event to incorrectly emit the new value as the old value.

This update fixes the code to ensure the correct data is emitted.

Resolve #15373.

Type of Change

…vent In `aptos-token-objects::collection`, the `set_description` and `set_uri` functions replace the data with the new value before emitting the event. This causes the Mutation V2 event to incorrectly emit the new value as the old value. This update fixes the code to ensure the correct data is emitted.

trunk-io · 2024-11-22T22:01:19Z

⏱️ 3h 11m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	1h 14m	🟩 🟩 🟩
execution-performance / test-target-determinator	14m	🟩 🟩 🟩
test-target-determinator	14m	🟩 ⬜ 🟩
rust-move-tests	13m	🟩
rust-move-tests	12m	🟩
rust-move-tests	12m	🟩
check	11m	🟩 🟩 🟩
rust-cargo-deny	7m	🟩 🟩 🟩 🟩
rust-doc-tests	6m	🟩
rust-doc-tests	5m	🟩
fetch-last-released-docker-image-tag	5m	🟩 🟩 🟩
rust-move-tests	4m	⬜
rust-doc-tests	4m	⬜
check-dynamic-deps	4m	🟩 🟩 🟩 🟩
general-lints	2m	🟩 🟩 🟩 🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

…vent (#15375) In `aptos-token-objects::collection`, the `set_description` and `set_uri` functions replace the data with the new value before emitting the event. This causes the Mutation V2 event to incorrectly emit the new value as the old value. This update fixes the code to ensure the correct data is emitted. (cherry picked from commit 0747561)

github-actions · 2024-11-27T00:04:16Z

💚 All backports created successfully

Status	Branch	Result
✅	aptos-release-v1.24

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

github-actions · 2024-11-27T00:31:22Z

✅ Forge suite `realistic_env_max_load` success on `51e573e67b2098393549aa07ade2edd1cc26fb24`

two traffics test: inner traffic : committed: 14471.66 txn/s, latency: 2749.86 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3600 ms), latency samples: 5502460
two traffics test : committed: 100.03 txn/s, latency: 1652.39 ms, (p50: 1400 ms, p70: 1400, p90: 1600 ms, p99: 11700 ms), latency samples: 1600
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.984, avg: 1.547", "ConsensusProposalToOrdered: max: 0.323, avg: 0.292", "ConsensusOrderedToCommit: max: 0.382, avg: 0.366", "ConsensusProposalToCommit: max: 0.671, avg: 0.659"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.90s no progress at version 2826001 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.52s no progress at version 2825999 (avg 8.52s) [limit 15].
Test Ok

github-actions · 2024-11-27T00:33:34Z

✅ Forge suite `framework_upgrade` success on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `51e573e67b2098393549aa07ade2edd1cc26fb24`

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 51e573e67b2098393549aa07ade2edd1cc26fb24 (PR)
Upgrade the nodes to version: 51e573e67b2098393549aa07ade2edd1cc26fb24
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1362.20 txn/s, submitted: 1365.10 txn/s, failed submission: 2.90 txn/s, expired: 2.90 txn/s, latency: 2188.58 ms, (p50: 1900 ms, p70: 2100, p90: 3200 ms, p99: 5100 ms), latency samples: 122180
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1405.19 txn/s, submitted: 1408.60 txn/s, failed submission: 3.42 txn/s, expired: 3.42 txn/s, latency: 2111.42 ms, (p50: 1800 ms, p70: 2100, p90: 3200 ms, p99: 4800 ms), latency samples: 123420
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 51e573e67b2098393549aa07ade2edd1cc26fb24 passed
Upgrade the remaining nodes to version: 51e573e67b2098393549aa07ade2edd1cc26fb24
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1442.66 txn/s, submitted: 1444.96 txn/s, failed submission: 2.30 txn/s, expired: 2.30 txn/s, latency: 2261.89 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 5400 ms), latency samples: 125320
Test Ok

github-actions · 2024-11-27T00:34:52Z

✅ Forge suite `compat` success on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `51e573e67b2098393549aa07ade2edd1cc26fb24`

Compatibility test results for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 51e573e67b2098393549aa07ade2edd1cc26fb24 (PR)
1. Check liveness of validators at old version: 010570d3b7aa20889fb5ad0e5b23800aa33f5634
compatibility::simple-validator-upgrade::liveness-check : committed: 14590.29 txn/s, latency: 2147.43 ms, (p50: 2100 ms, p70: 2100, p90: 2200 ms, p99: 7500 ms), latency samples: 552800
2. Upgrading first Validator to new version: 51e573e67b2098393549aa07ade2edd1cc26fb24
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 8032.74 txn/s, latency: 3597.63 ms, (p50: 4000 ms, p70: 4200, p90: 4300 ms, p99: 4300 ms), latency samples: 148640
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7313.47 txn/s, latency: 4356.84 ms, (p50: 4300 ms, p70: 4300, p90: 6800 ms, p99: 7100 ms), latency samples: 249520
3. Upgrading rest of first batch to new version: 51e573e67b2098393549aa07ade2edd1cc26fb24
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7389.45 txn/s, latency: 3880.10 ms, (p50: 4300 ms, p70: 4600, p90: 4700 ms, p99: 4900 ms), latency samples: 137660
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6723.23 txn/s, latency: 4526.84 ms, (p50: 4600 ms, p70: 4700, p90: 4900 ms, p99: 6600 ms), latency samples: 252220
4. upgrading second batch to new version: 51e573e67b2098393549aa07ade2edd1cc26fb24
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10520.89 txn/s, latency: 2615.19 ms, (p50: 2600 ms, p70: 2800, p90: 3900 ms, p99: 4100 ms), latency samples: 189380
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10760.24 txn/s, latency: 2911.26 ms, (p50: 2700 ms, p70: 2900, p90: 5400 ms, p99: 6600 ms), latency samples: 349420
5. check swarm health
Compatibility test for 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 51e573e67b2098393549aa07ade2edd1cc26fb24 passed
Test Ok

junkil-park requested review from davidiw, movekevin and wrwg as code owners November 22, 2024 22:01

junkil-park requested a review from lightmark November 22, 2024 22:01

lightmark approved these changes Nov 23, 2024

View reviewed changes

JohnChangUK approved these changes Nov 23, 2024

View reviewed changes

junkil-park enabled auto-merge (squash) November 23, 2024 20:18

This comment has been minimized.

Sign in to view

junkil-park merged commit 0747561 into main Nov 23, 2024
94 checks passed

junkil-park deleted the jpark/fix-mutation-v2-event branch November 23, 2024 20:54

lightmark added cherry-pick v1.24 labels Nov 26, 2024

github-actions bot mentioned this pull request Nov 27, 2024

[cp][aptos-release-v1.24] Fix Emitted Data for aptos-token-objects::collection::Mutation V2 Event #15409

Open

This comment has been minimized.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Emitted Data for `aptos-token-objects::collection::Mutation` V2 Event #15375

Fix Emitted Data for `aptos-token-objects::collection::Mutation` V2 Event #15375

junkil-park commented Nov 22, 2024 •

edited

Loading

trunk-io bot commented Nov 22, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Nov 27, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

Fix Emitted Data for aptos-token-objects::collection::Mutation V2 Event #15375

Fix Emitted Data for aptos-token-objects::collection::Mutation V2 Event #15375

Conversation

junkil-park commented Nov 22, 2024 • edited Loading

Description

Type of Change

trunk-io bot commented Nov 22, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Nov 27, 2024

💚 All backports created successfully

Questions ?

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Nov 27, 2024

✅ Forge suite realistic_env_max_load success on 51e573e67b2098393549aa07ade2edd1cc26fb24

github-actions bot commented Nov 27, 2024

✅ Forge suite framework_upgrade success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 51e573e67b2098393549aa07ade2edd1cc26fb24

github-actions bot commented Nov 27, 2024

✅ Forge suite compat success on 010570d3b7aa20889fb5ad0e5b23800aa33f5634 ==> 51e573e67b2098393549aa07ade2edd1cc26fb24

Fix Emitted Data for `aptos-token-objects::collection::Mutation` V2 Event #15375

Fix Emitted Data for `aptos-token-objects::collection::Mutation` V2 Event #15375

junkil-park commented Nov 22, 2024 •

edited

Loading

trunk-io bot commented Nov 22, 2024 •

edited

Loading

✅ Forge suite `realistic_env_max_load` success on `51e573e67b2098393549aa07ade2edd1cc26fb24`

✅ Forge suite `framework_upgrade` success on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `51e573e67b2098393549aa07ade2edd1cc26fb24`

✅ Forge suite `compat` success on `010570d3b7aa20889fb5ad0e5b23800aa33f5634` ==> `51e573e67b2098393549aa07ade2edd1cc26fb24`