[events] Fix event GUID parsing #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnazario
force-pushed
the
fix-event-parsing
branch
from
312a90e
to
978253c
Compare
gregnazario
force-pushed
the
fix-event-parsing
branch
from
978253c
to
8eceda3
Compare
GhostWalker562
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are two formats, one for resources, and one for events. I wrongly formatted the resource format to parse the event format. This fixes it. Thanks @jmmcatee for pointing it out!
Test Plan
Fixed the event tests accordingly to match the other copied test inputs.
Related Links
Closes #75