Update unit test to check primary name is always cleared in v1 after set in v2 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xaptosj
commented
Sep 22, 2023
| @@ -154,11 +154,17 @@ module router::migration_tests { | |||
| // Make v1 read only except for admin | |||
| aptos_names::config::set_is_enabled(aptos_names, false); | |||
|
|
|||
| // Migration fails because user2 does not own `domain_name` | |||
There was a problem hiding this comment.
this is copied by mistake
angieyth
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever primary name is set in v2, it should be cleared in v1 because of this line, adding unit test to make sure of that