Allow setting target address and transfer to address during registration

[0xaptosj]

Summary

1. rename set_reverse_lookup to set_name_address_and_reverse_lookup to avoid confusion.
2. change the logic on when to set_name_address_and_reverse_lookup

previous behavior	new behavior
if signer doesn't have a primary name (either due to first time buying a name, or had once but cleared)	on top of previous behavior, we check another condition should_set_reverse_lookup_and_target_addres_result, this returns true only when signer set both target address and transfer to address to itself, then we set primary name

    public fun should_set_reverse_lookup_and_target_address(
        signer_address: address,
        target_address: Option<address>,
        transfer_to_address: Option<address>,
    ): bool {
        let transfer_to_address = option::get_with_default(&transfer_to_address, signer_address);
        let target_address = option::get_with_default(&target_address, signer_address);
        if (target_address == signer_address && transfer_to_address == signer_address) {
            true
        } else {
            false
        }
    }

3. change the logic on when to set target address

previous behavior	new behavior
if primary name is set, target address will be set along, or user is registering a domain. in both cases, target address is set to the signer	on top of previous behavior, also set target address if it's passed explicitly, in this case even signer is registering a subdomain we still set target address

    public fun should_set_target_address_in_register_name(
        subdomain_name: Option<String>,
        target_address: Option<address>,
    ): bool {
        if (!is_subdomain(subdomain_name)) {
            // If signer is registering a domain, automatically set the name to point to target address, if not set use signer address
            true
        }
        else if (option::is_some(&target_address)) {
            // Else if target address is explicitly provided, set it
            true
        }
        else {
            // Else signer is registering a subdomain and target address not explicitly set, leave it as none
            false
        }
    }

[angieyth]

do you think we should add an unit test for transfer and another one for target address? (I sound like brian :P)

[0xaptosj]

do you think we should add an unit test for transfer and another one for target address? (I sound like brian :P)

I should, im figuring out how, your are right unit test is the most painful thing

[angieyth]

is it possible to separate the logic of reverse look up and set target address in should_set_reverse_lookup_and_target_address_in_register_name

I see we also have should_set_target_address_in_register_name and it's confusing

[0xaptosj]

it's because set reverse lookup will always set target address at the same time, if i break it into 2, i need to break set_target_address_and_reverse_lookup

[angieyth]

I do think we should break set_target_address_and_reverse_lookup :P
because those are basically two different things. aren't them?
you set primary name when the buyer is the owner
you set target address whenever there's a value passing in?

[angieyth]

I do think we should break set_target_address_and_reverse_lookup :P
because those are basically two different things. aren't them?
you set primary name when the buyer is the owner
you set target address whenever there's a value passing in?

[angieyth]

I don't understand this case, can you elaborate?

[0xaptosj]

updated the comment, basically when registering a domain, we always set the target address of the new domain