Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] queryIndexer should return an error if the request fails #349

Open
BriungRi opened this issue Apr 3, 2024 · 1 comment
Open

[Feature Request] queryIndexer should return an error if the request fails #349

BriungRi opened this issue Apr 3, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@BriungRi
Copy link

BriungRi commented Apr 3, 2024 •
edited
Loading

🚀 Feature Request Description

aptos.queryIndexer currently only returns the data. Either it does not exist or it is not automatically included in the type signature where a developer can see an error or error code.

Motivation

aptos.queryIndexer is a fallible API, and I think it is important for developers to be able to debug any errors that come from this endpoint.

Pitch

Describe the solution you would like
aptos.queryIndexer should always return data and error. error can be nullable.

Describe alternatives you've considered
Might need to use a GraphQL client directly
@BriungRi BriungRi added the enhancement New feature or request label Apr 3, 2024
@gregnazario
Copy link
Collaborator

Which version of the SDK are you using? It should return throw an error if the indexer query fails.

Can you provide an example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
SDKs and Tools
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregnazario @BriungRi